vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

chore: use es6 imports for deploy-preview-netlify #2970

Merged
konrad merged 2 commits from dpschen/frontend:feature/netlify-es6-imports into main 2023-01-18 15:54:47 +00:00
Conversation 6 Commits 2 Files Changed 4 +7 -5
dpschen commented 2023-01-17 14:28:36 +00:00
Member
Copy Link
No description provided.
dpschen added the
changes requested
area/internal-code
 labels 2023-01-17 14:28:36 +00:00
konrad was assigned by dpschen 2023-01-17 14:28:36 +00:00
konrad scheduled this pull request to auto merge when all checks succeed 2023-01-17 14:29:45 +00:00
dpschen commented 2023-01-18 14:07:35 +00:00
Author
Member
Copy Link

@konrad only the deploy preview fails here because the checksum did NOT match

@konrad only the deploy preview fails here because `the checksum did NOT match`
dpschen requested review from konrad 2023-01-18 14:07:42 +00:00
konrad commented 2023-01-18 14:21:14 +00:00
Owner
Copy Link

Should be fixed now.

Should be fixed now.
dpschen commented 2023-01-18 15:29:50 +00:00
Author
Member
Copy Link

Should be fixed now.

SyntaxError: Cannot use import statement outside a module

:D :D

oops

> Should be fixed now. ``` SyntaxError: Cannot use import statement outside a module ``` :D :D oops
dpschen force-pushed feature/netlify-es6-imports from 827f9066cd to a379832b0b 2023-01-18 15:39:04 +00:00 Compare
dpschen commented 2023-01-18 15:39:28 +00:00
Author
Member
Copy Link

Trying again with a mjs file.

Trying again with a `mjs` file.
konrad added 1 commit 2023-01-18 15:45:18 +00:00
chore(ci): sign drone config
All checks were successful
continuous-integration/drone/pr Build is passing
Details
15d2a033c5
frederick commented 2023-01-18 15:48:38 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2970-feature-netlify-es6-imports--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2970-feature-netlify-es6-imports--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad merged commit 2a2c27af92 into main 2023-01-18 15:54:38 +00:00
dpschen deleted branch feature/netlify-es6-imports 2023-01-18 15:58:10 +00:00
dpschen commented 2023-01-18 15:58:18 +00:00
Author
Member
Copy Link

🥳

🥳
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
konrad
Labels
Clear labels
area/internal-code
changes requested
confirmed
dependencies
duplicate
This issue or pull request already exists
good first issue
help wanted
Need some help
hosting
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
question
More information is needed
wontfix
This won't be fixed
No Label
area/internal-code
changes requested
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees konrad
3 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/frontend#2970
No description provided.
Delete Branch "dpschen/frontend:feature/netlify-es6-imports"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?