vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Better reminders #308

Merged
konrad merged 37 commits from feature/better-reminders into master 2020-11-28 13:59:28 +00:00
Conversation 0 Commits 37 Files Changed 15 +2253 -152
konrad commented 2020-11-22 21:54:08 +00:00
Owner
Copy Link

This PR adds better reminders to choose from for tasks:

image

TODO

  • Fix selecting dates with the custom date picker
  • Make sure all elements inside the component are clickable - This may require more magic in the close() function to simply check if the parent of the clicked dom element is the component div
  • Responsiveness / make it all work on mobile, maybe requires using more of the native datepicker inputs
  • Use the component everywhere where it makes sense (on all the date fields on the task detail view at least)
  • Add a disabled prop to disable the component
  • Add a "confirm" button on the bottom of the component which just closes it
  • When choosing today when the time is past 21:00 the time is set to 9:00 today which does not make sense. In that case, maybe don't set it? Or simply don't provide the "today" option after 21:00 since one probably won't set dates due for today if they're already kinda done for the day - and even if, there's still the custom date picker.
  • Don't save the reminders if the date didn't change - e.g. if the picker has been openend and closed right away without selecting any date.
This PR adds better reminders to choose from for tasks: ![image](/attachments/10af294a-b967-4a37-bcc6-531bc393bfb5) ## TODO * [x] Fix selecting dates with the custom date picker * [x] Make sure all elements inside the component are clickable - This may require more magic in the close() function to simply check if the parent of the clicked dom element is the component div * [x] Responsiveness / make it all work on mobile, maybe requires using more of the native datepicker inputs * [x] Use the component everywhere where it makes sense (on all the date fields on the task detail view at least) * [x] Add a `disabled` prop to disable the component * [x] Add a "confirm" button on the bottom of the component which just closes it * [x] When choosing today when the time is past 21:00 the time is set to 9:00 today which does not make sense. In that case, maybe don't set it? Or simply don't provide the "today" option after 21:00 since one probably won't set dates due for today if they're already kinda done for the day - and even if, there's still the custom date picker. * [x] Don't save the reminders if the date didn't change - e.g. if the picker has been openend and closed right away without selecting any date.
image.png
36 KiB
konrad added 4 commits 2020-11-22 21:54:09 +00:00
continuous-integration/drone/pr Build is failing Details
a3f902dd18
Add tests to dron
konrad added 1 commit 2020-11-22 22:08:09 +00:00
continuous-integration/drone/pr Build is passing Details
4be7cd5fce
Ignore test files when linting
konrad added 1 commit 2020-11-25 16:55:26 +00:00
continuous-integration/drone/pr Build is passing Details
96d27c6bb9
Use a different icon for weekend
konrad added 1 commit 2020-11-25 17:00:59 +00:00
konrad added 1 commit 2020-11-25 17:02:08 +00:00
konrad added 1 commit 2020-11-25 17:12:18 +00:00
continuous-integration/drone/pr Build is failing Details
ff0044f547
Show correct weekday in preview
konrad added 1 commit 2020-11-25 17:13:43 +00:00
continuous-integration/drone/pr Build is passing Details
c75549abcb
Fix test
konrad added 2 commits 2020-11-25 17:20:48 +00:00
continuous-integration/drone/pr Build is passing Details
5c29b3e69b
Bubble
konrad added 1 commit 2020-11-25 17:27:21 +00:00
continuous-integration/drone/pr Build is passing Details
010397d64a
Better formatting of the chosen date
konrad added 2 commits 2020-11-25 17:34:59 +00:00
continuous-integration/drone/pr Build is passing Details
98e1b6eaaa
Cleanup
konrad added 1 commit 2020-11-25 17:37:29 +00:00
continuous-integration/drone/pr Build is passing Details
17c882dfbf
Remove separate flatpickr date
konrad added 2 commits 2020-11-25 17:50:27 +00:00
continuous-integration/drone/pr Build is passing Details
a5905a87e2
Add method to calculate the neares time
konrad added 1 commit 2020-11-25 17:51:48 +00:00
continuous-integration/drone/pr Build is passing Details
a60ef1c6df
Set time
konrad added 1 commit 2020-11-25 21:17:37 +00:00
continuous-integration/drone/pr Build is passing Details
6834e30783
Fix bottom padding of inline flatpickr
konrad added 1 commit 2020-11-26 20:34:52 +00:00
continuous-integration/drone/pr Build is passing Details
879df824f1
Merge branch 'master' into feature/better-reminders
konrad added 1 commit 2020-11-26 21:27:37 +00:00
continuous-integration/drone/pr Build is passing Details
33b9160a24
Use datepicker component for reminders
konrad added 1 commit 2020-11-28 11:53:34 +00:00
continuous-integration/drone/pr Build is passing Details
85ce39eca0
Make flatpickr dates work
konrad added 1 commit 2020-11-28 12:07:44 +00:00
konrad added 1 commit 2020-11-28 12:09:31 +00:00
continuous-integration/drone/pr Build is passing Details
6addbcf8bd
Sync flatpickr when clicking on choose a date
konrad added 2 commits 2020-11-28 12:13:24 +00:00
continuous-integration/drone/pr Build is passing Details
468ec9c2c5
Mobile styling
konrad added 1 commit 2020-11-28 12:29:08 +00:00
continuous-integration/drone/pr Build is passing Details
390afe1f81
Use the new datepicker for due dates
konrad added 1 commit 2020-11-28 12:40:58 +00:00
continuous-integration/drone/pr Build is passing Details
972eb5acfc
Use the new datepicker for start date
konrad added 1 commit 2020-11-28 12:42:41 +00:00
continuous-integration/drone/pr Build is passing Details
edbf3109ef
Use the new datepicker for end dates
konrad added 1 commit 2020-11-28 12:46:34 +00:00
continuous-integration/drone/pr Build is passing Details
590edc4f82
Cleanup workarounds for flatpickr
konrad added 1 commit 2020-11-28 12:52:33 +00:00
continuous-integration/drone/pr Build is passing Details
68c48b5792
Add a disabled property to the datepicker
konrad added 1 commit 2020-11-28 12:53:31 +00:00
continuous-integration/drone/pr Build is passing Details
776c6041f2
Use disabled in reminders
konrad added 1 commit 2020-11-28 13:06:32 +00:00
continuous-integration/drone/pr Build is passing Details
d68b4d6dd7
Add "confirm" button to close the component
konrad added 1 commit 2020-11-28 13:08:06 +00:00
continuous-integration/drone/pr Build is passing Details
231aca249a
Hide the "today" option after 21:00
konrad added 1 commit 2020-11-28 13:19:54 +00:00
konrad added 1 commit 2020-11-28 13:22:22 +00:00
konrad changed title from WIP: Better reminders to Better reminders 2020-11-28 13:22:37 +00:00
konrad merged commit fb3cf94cba into master 2020-11-28 13:59:28 +00:00
konrad referenced this issue from a commit 2020-11-28 13:59:28 +00:00
Better reminders (#308)
konrad deleted branch feature/better-reminders 2020-11-28 13:59:38 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#308
No description provided.
Delete Branch "feature/better-reminders"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?