Labels Milestones

feat: use renovate js-app as preset #3087

Merged

konrad merged 1 commits from dpschen/frontend:feature/renovates-js-app-preset into main 1 month ago

Conversation 6 Commits 1 Files Changed 1

dpschen commented 1 month ago

Collaborator

Unsure about this. Just stumbled over this option and thought it might make sense.

Unsure about this. Just stumbled over this option and thought it might make sense.

dpschen added 1 commit 1 month ago

cda681c59d

feat: use renovate js-app as preset

dpschen requested review from konrad 1 month ago

konrad was assigned by dpschen 1 month ago

dpschen added the area/internal-code label 1 month ago

frederick commented 1 month ago

Collaborator

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3087-feature-renovates-js-app-preset--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3087-feature-renovates-js-app-preset--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad commented 1 month ago

Owner

Well what does it do?

Well what does it do?

😆 1

dpschen commented 1 month ago

Poster

Collaborator

Well what does it do?

See in the docs.
Seems like only the setting pinAllExceptPeerDependencies was added. Do you think that makes sense?

> Well what does it do? See in [the docs](https://docs.renovatebot.com/presets-config/#configjs-app). Seems like only the setting [`pinAllExceptPeerDependencies`](https://docs.renovatebot.com/presets-default/#pinallexceptpeerdependencies) was added. Do you think that makes sense?

konrad commented 1 month ago

Owner

Aren't peer dependencies not included in the package.json as well?

Aren't peer dependencies not included in the package.json as well?

dpschen commented 1 month ago

Poster

Collaborator

Aren't peer dependencies not included in the package.json as well?

They should be. See the link for details what exactly that config does.

> Aren't peer dependencies not included in the package.json as well? They should be. See the link for details what exactly that config does.

konrad commented 1 month ago

Owner

Yeah okay I think that makes sense.

Yeah okay I think that makes sense.

konrad referenced this issue from a commit 1 month ago

feat: use renovate js-app as preset (#3087)

konrad merged commit 97c8970dd6 into main 1 month ago

konrad deleted branch feature/renovates-js-app-preset 1 month ago

Reviewers

konrad was requested for review 1 month ago

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as 97c8970dd6.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

konrad

Labels

Apply labels

Clear labels

area/internal-code changes requested dependencies duplicate
This issue or pull request already exists help wanted
Need some help hosting invalid
Something is wrong kind/bug
Something is not working kind/feature
New feature question
More information is needed wontfix
This won't be fixed

No Label area/internal-code changes requested dependencies duplicate help wanted hosting invalid kind/bug kind/feature question wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

konrad

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3087

Write Preview

Loading…

Cancel

Save

There is no content yet.