vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: use renovate js-app as preset #3087

Merged
konrad merged 1 commits from dpschen/frontend:feature/renovates-js-app-preset into main 2023-02-15 21:58:36 +00:00
Conversation 6 Commits 1 Files Changed 1 +1 -1
dpschen commented 2023-02-09 18:01:43 +00:00
Member
Copy Link

Unsure about this. Just stumbled over this option and thought it might make sense.

Unsure about this. Just stumbled over this option and thought it might make sense.
dpschen added 1 commit 2023-02-09 18:01:43 +00:00
continuous-integration/drone/pr Build is passing Details
cda681c59d
feat: use renovate js-app as preset
dpschen requested review from konrad 2023-02-09 18:01:47 +00:00
konrad was assigned by dpschen 2023-02-09 18:01:51 +00:00
dpschen added the
area/internal-code
 label 2023-02-09 18:01:56 +00:00
frederick commented 2023-02-09 18:05:27 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3087-feature-renovates-js-app-preset--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3087-feature-renovates-js-app-preset--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2023-02-09 21:00:03 +00:00
Owner
Copy Link

Well what does it do?

Well what does it do?
😆 1
dpschen commented 2023-02-15 14:41:45 +00:00
Author
Member
Copy Link

Well what does it do?

See in the docs.
Seems like only the setting pinAllExceptPeerDependencies was added. Do you think that makes sense?

> Well what does it do? See in [the docs](https://docs.renovatebot.com/presets-config/#configjs-app). Seems like only the setting [`pinAllExceptPeerDependencies`](https://docs.renovatebot.com/presets-default/#pinallexceptpeerdependencies) was added. Do you think that makes sense?
konrad commented 2023-02-15 15:41:30 +00:00
Owner
Copy Link

Aren't peer dependencies not included in the package.json as well?

Aren't peer dependencies not included in the package.json as well?
dpschen commented 2023-02-15 19:31:30 +00:00
Author
Member
Copy Link

Aren't peer dependencies not included in the package.json as well?

They should be. See the link for details what exactly that config does.

> Aren't peer dependencies not included in the package.json as well? They should be. See the link for details what exactly that config does.
konrad commented 2023-02-15 21:58:21 +00:00
Owner
Copy Link

Yeah okay I think that makes sense.

Yeah okay I think that makes sense.
konrad merged commit 97c8970dd6 into main 2023-02-15 21:58:36 +00:00
konrad deleted branch feature/renovates-js-app-preset 2023-02-15 21:58:36 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3087
No description provided.
Delete Branch "dpschen/frontend:feature/renovates-js-app-preset"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?