vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

refactor: improve stores/config types #3190

Merged
konrad merged 2 commits from WofWca/frontend:refactor into main 2023-03-03 14:37:01 +00:00
Conversation 1 Commits 2 Files Changed 3 +10 -8
WofWca commented 2023-03-03 11:48:24 +00:00
Contributor
Copy Link
No description provided.
frederick commented 2023-03-03 11:51:49 +00:00
Member
Copy Link

Hi WofWca!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3190-refactor--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi WofWca! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3190-refactor--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2023-03-03 14:11:32 +00:00
src/stores/config.ts
@ -84,2 +85,3 @@
setConfig(objectToCamelCase(config))
return config
const success = !!config
return success
konrad commented 2023-03-03 14:11:32 +00:00
Owner

Why not Boolean(config)? Or something like Object.keys(config).length > 0?

Why not `Boolean(config)`? Or something like `Object.keys(config).length > 0`?
WofWca commented 2023-03-03 14:18:33 +00:00
Author
Contributor

No particular reason. I'm just used to !!, and I tried to keep the logic the same.

No particular reason. I'm just used to `!!`, and I tried to keep the logic the same.
konrad commented 2023-03-03 14:23:49 +00:00
Owner

Fair enough.

Fair enough.
konrad marked this conversation as resolved
konrad force-pushed refactor from 986bc56039 to 0954984792 2023-03-03 14:26:03 +00:00 Compare
konrad approved these changes 2023-03-03 14:26:18 +00:00
konrad scheduled this pull request to auto merge when all checks succeed 2023-03-03 14:26:29 +00:00
konrad merged commit 6a3518dace into main 2023-03-03 14:37:01 +00:00
WofWca deleted branch refactor 2023-03-03 17:33:10 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3190
No description provided.
Delete Branch "WofWca/frontend:refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?