chore: improve @/message action type #3209

Merged
konrad merged 1 commits from WofWca/frontend:types into main 2023-03-08 09:52:04 +00:00
Contributor
No description provided.
Member

Hi WofWca!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3209-types--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi WofWca! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3209-types--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2023-03-08 09:26:31 +00:00
@ -729,3 +729,3 @@
setActiveFields()
let actions = []
let actions: Parameters<typeof success>[1] = []

Why not export the

Why not export the
Author
Contributor

This looks simpler to me, easier to change and understand.

This looks simpler to me, easier to change and understand.

whoops sorry, looks like my comment was cut off.

I meant to say: Why not export the new Action type and use that here?

whoops sorry, looks like my comment was cut off. I meant to say: Why not export the new `Action` type and use that here?
Author
Contributor

Yeah, I got what you mean.

Yeah, I got what you mean.

I know how this does the same thing but it took me longer to understand. Can you still change it?

I know how this does the same thing but it took me longer to understand. Can you still change it?
WofWca marked this conversation as resolved
WofWca force-pushed types from 0c73a7c4d8 to dcd7648300 2023-03-08 09:40:10 +00:00 Compare
konrad approved these changes 2023-03-08 09:40:32 +00:00
konrad left a comment
Owner

Awesome, thank you!

Awesome, thank you!
konrad scheduled this pull request to auto merge when all checks succeed 2023-03-08 09:40:42 +00:00
konrad merged commit 0eb78e32f9 into main 2023-03-08 09:51:58 +00:00
WofWca deleted branch types 2023-03-08 10:00:14 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.