vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix(i18n): load language files before doing anything else #3218

Merged
konrad merged 2 commits from fix/load-language-files into main 2023-03-10 13:46:25 +00:00
Conversation 8 Commits 2 Files Changed 1 +59 -57
konrad commented 2023-03-09 12:13:20 +00:00
Owner
Copy Link

Resolves #3214

Resolves #3214
konrad added 1 commit 2023-03-09 12:13:21 +00:00
continuous-integration/drone/pr Build is failing Details
ee2e313ed8
fix(i18n): load language files before doing anything else 
Resolves #3214
konrad commented 2023-03-09 12:15:15 +00:00
Author
Owner
Copy Link

This PR fixes the problem mentioned in the issue, but I'm not 100% sure about the cause of it. In simply loading the language before doing anything else, the watcher is only executed once the language files are correctly in the browser. I suspect registering the watcher happens before the app is mounted?

This PR fixes the problem mentioned in the issue, but I'm not 100% sure about the cause of it. In simply loading the language before doing anything else, the watcher is only executed once the language files are correctly in the browser. I suspect registering the watcher happens before the app is mounted?
konrad requested review from dpschen 2023-03-09 12:15:19 +00:00
dpschen was assigned by konrad 2023-03-09 12:15:23 +00:00
konrad added 1 commit 2023-03-09 12:42:42 +00:00
continuous-integration/drone/pr Build is passing Details
f9c42c737d
fix(i18n): top level await
frederick commented 2023-03-09 12:47:29 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3218-fix-load-language-files--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3218-fix-load-language-files--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen commented 2023-03-09 20:22:48 +00:00
Member
Copy Link

I suspect registering the watcher happens before the app is mounted?

I guess this is because of the vue life cycle.

  1. (script setup)
  2. created
  3. mounted

(with steps in between)

> I suspect registering the watcher happens before the app is mounted? I guess this is because of the vue life cycle. 1) (script setup) 2) created 3) mounted (with steps in between)
dpschen reviewed 2023-03-09 20:35:55 +00:00
src/main.ts
@ -39,74 +39,76 @@ if (window.API_URL.slice(window.API_URL.length - 1, window.API_URL.length) === '
window.API_URL = window.API_URL.slice(0, window.API_URL.length - 1)
}
const app = createApp(App)
dpschen commented 2023-03-09 20:35:55 +00:00
Member

Would it work if we save the returned promise of setLanguage and load it in parallel to all the stuff until mounting the app?

const languageLoaded = setLanguage()
const app = createApp(App)

// [...]

languageLoaded.then(() => {
	app.mount('#app')
})
Would it work if we save the returned promise of `setLanguage` and load it in parallel to all the stuff until mounting the app? ```ts const languageLoaded = setLanguage() const app = createApp(App) // [...] languageLoaded.then(() => { app.mount('#app') }) ```
konrad commented 2023-03-09 20:50:42 +00:00
Author
Owner

That's how it is done right now, but that does not seem to work.

That's how it is done right now, but that does not seem to work.
konrad commented 2023-03-09 21:10:17 +00:00
Author
Owner

It looks like the language needs to be loaded before the Vue Lifecycle starts.

It looks like the language needs to be loaded before the Vue Lifecycle starts.
konrad commented 2023-03-10 13:45:10 +00:00
Author
Owner

Actually tried it again but even got an error here TypeError: route is undefined.

Actually tried it again but even got an error here `TypeError: route is undefined`.
dpschen commented 2023-03-10 14:17:17 +00:00
Member

That's weird. I just tried this myself and couldn't trigger that error.

That's weird. I just tried this myself and couldn't trigger that error.
konrad merged commit 013472e899 into main 2023-03-10 13:46:25 +00:00
konrad deleted branch fix/load-language-files 2023-03-10 13:46:25 +00:00
dpschen commented 2023-03-10 14:16:43 +00:00
Member
Copy Link

Unsure if this was the case before, but right now it doesn't load the user language if it's not english for me.

Unsure if this was the case before, but right now it doesn't load the user language if it's not english for me.
konrad commented 2023-03-10 14:18:43 +00:00
Author
Owner
Copy Link

You mena it does not load it at all?

You mena it does not load it at all?
👍 1
dpschen commented 2023-03-10 14:20:06 +00:00
Member
Copy Link

Yes. It's not translated. I have to manually save the user settings again (that show the correct saved language) to trigger the loading of the language.

Yes. It's not translated. I have to manually save the user settings again (that show the correct saved language) to trigger the loading of the language.
konrad commented 2023-03-10 14:39:02 +00:00
Author
Owner
Copy Link

That's really wired. Is it reproducible on try?

That's really wired. Is it reproducible on try?
dpschen commented 2023-03-10 15:17:31 +00:00
Member
Copy Link

That's really wired. Is it reproducible on try?

It was in the test branch of this pr. So I guess it should also exist on try.

> That's really wired. Is it reproducible on try? It was in the test branch of this pr. So I guess it should also exist on try.
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dpschen
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3218
No description provided.
Delete Branch "fix/load-language-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?