vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix(task): make sure the modal close button is not overlapped with the title field #3256

Merged
konrad merged 2 commits from fix/task-detail-close-button-position into main 2023-10-22 17:40:53 +00:00
Conversation 3 Commits 2 Files Changed 3 +12 -3
konrad commented 2023-03-16 18:55:38 +00:00
Owner
Copy Link

Fixes #3252

Fixes https://kolaente.dev/vikunja/frontend/issues/3252
konrad added 1 commit 2023-03-16 18:55:38 +00:00
frederick commented 2023-03-16 18:59:28 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3256-fix-task-detail-close-button-pos--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3256-fix-task-detail-close-button-pos--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen commented 2023-03-22 15:20:07 +00:00
Member
Copy Link

This seems to break image

This seems to break ![image](/attachments/991879a7-e0fe-4dfa-bff5-43d4ed1f57aa)
image.png
26 KiB
konrad commented 2023-03-23 21:02:37 +00:00
Author
Owner
Copy Link

@dpschen Which breakpoint is that?

@dpschen Which breakpoint is that?
konrad force-pushed fix/task-detail-close-button-position from e8307d254b to 9ef592c5d0 2023-10-22 17:21:09 +00:00 Compare
konrad merged commit 0b294de132 into main 2023-10-22 17:40:53 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3256
No description provided.
Delete Branch "fix/task-detail-close-button-position"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?