WIP: fix: replace the "Mark as done/undone" button with checkbox #3279
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
4 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#3279
Loading…
Reference in New Issue
No description provided.
Delete Branch "WofWca/frontend:replace-done-button-with-checkbox"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This makes it more intuitive, makes you think less.
The color is confusing as well IMO as you don't know whether the green button means "make it good" or "it is good now".
TODO:
Before:
After:
Hi WofWca!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://3279-replace-done-button-with-checkbo--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
Personally I would prefer to replace the current done badge completely and put the checkbox in front of the task title. After that we could remove that action button completely.
My reason here is that we could reduce clutter while at the same time align task that are shown in list form with the ones on the task detail page.
Personally, I like being able to smash a button to mark a task done. A checkbox wouldn't do that feeling justice.
That being said, I understand why a checkbox might be a better case here, but then it looks out of place with the other buttons.
It was called "done" before, but people thought it meant "done with editing this task" and were confused when it instead marked the task done.
I understand that for a button "Mark as done" is better than "Done", but I think for a checkbox "Done" is better.
That sounds almost insulting to the FancyCheckbox 😆. But I understand that one gets used to finish the task via the button at that position.
If you imagine a redesign of the whole task detail I would personally start by aligning the task shown in a list with the one that title of the detail page. In the list view some additional details might be displayed via icons etc. In the Task detail we have the meta section for that. Continuing with this thought I think we should merge / align the actions and their coresponding display area. So that a usere doesn't had to jump from the action button to the meta info. By merging this we reduce visual clutter and complexity.
The latter is the same reason why I would prefer to get rid of the 'mark done' action button at its current location. I do get though that applying this change without adjusting the actions might add more harm than keeping the current state.
Okay, but if we go with the checkbox instead of the button, we should move it to the left of the title.
I'm still not sure if this is a good idea. I feel like this would be a big change which makes the way to mark a task done less obvious.
That's true. As said I think this should be part of something where we completely rethink the detail page. Opt-in might make sense in the beginning in order to gain feedback.
Less obvious to current users? Yes. Less obvious to new users? I disagree. I think besides the title is a more intuitive place.
Let's consider making this a setting, or keeping keeping the button and adding the checkbox.
I think that could work. And then maybe remove the button once everyone knows about the checkbos.
hey @WofWca are you still interested in this?
In a sense that whether I personally need this changed - no, and not in the foreseeable future.