WIP: fix: replace the "Mark as done/undone" button with checkbox #3279

Closed
WofWca wants to merge 1 commits from WofWca/frontend:replace-done-button-with-checkbox into main
Contributor

This makes it more intuitive, makes you think less.

The color is confusing as well IMO as you don't know whether the green button means "make it good" or "it is good now".

TODO:

  • Adjust styles.
  • What do with the now unused i18n strings? They don't quite fit with the checkbox as they represent actions ("mark as") and not state ("done").
  • Consider moving the checkbox somewhere else, say beside the title (replace the green "done" badge), like in the task list view (and Todoist).
  • Also look at how the "Favorite" button works, it's similar

Before:
image

After:
image

This makes it more intuitive, makes you think less. The color is confusing as well IMO as you don't know whether the green button means "make it good" or "it is good now". TODO: * [ ] Adjust styles. * [ ] What do with the now unused i18n strings? They don't quite fit with the checkbox as they represent actions ("mark as") and not state ("done"). * [ ] Consider moving the checkbox somewhere else, say beside the title (replace the green "done" badge), like in the task list view (and Todoist). * [ ] Also look at how the "Favorite" button works, it's similar Before: ![image](/attachments/31e71dd2-466f-4328-8ecf-94ce7347839b) After: ![image](/attachments/d9b0e191-5e18-4ee0-8668-12ae9652ff42)
WofWca added 1 commit 2023-03-21 11:39:55 +00:00
continuous-integration/drone/pr Build is failing Details
80167f24ea
WIP: fix: replace the "Mark as done/undone" button with checkbox
This makes it more intuitive, makes you think less
Member

Hi WofWca!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3279-replace-done-button-with-checkbo--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi WofWca! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3279-replace-done-button-with-checkbo--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
Member

Personally I would prefer to replace the current done badge completely and put the checkbox in front of the task title. After that we could remove that action button completely.

My reason here is that we could reduce clutter while at the same time align task that are shown in list form with the ones on the task detail page.

Personally I would prefer to replace the current done badge completely and put the checkbox in front of the task title. After that we could remove that action button completely. My reason here is that we could reduce clutter while at the same time align task that are shown in list form with the ones on the task detail page.
Owner

Personally, I like being able to smash a button to mark a task done. A checkbox wouldn't do that feeling justice.

That being said, I understand why a checkbox might be a better case here, but then it looks out of place with the other buttons.

What do with the now unused i18n strings? They don't quite fit with the checkbox as they represent actions ("mark as") and not state ("done").

It was called "done" before, but people thought it meant "done with editing this task" and were confused when it instead marked the task done.

Personally, I like being able to smash a button to mark a task done. A checkbox wouldn't do that feeling justice. That being said, I understand why a checkbox might be a better case here, but then it looks out of place with the other buttons. > What do with the now unused i18n strings? They don't quite fit with the checkbox as they represent actions ("mark as") and not state ("done"). It was called "done" before, but people thought it meant "done with editing this task" and were confused when it instead marked the task done.
Author
Contributor

It was called "done" before, but people thought it meant "done with editing this task" and were confused when it instead marked the task done.

I understand that for a button "Mark as done" is better than "Done", but I think for a checkbox "Done" is better.

> It was called "done" before, but people thought it meant "done with editing this task" and were confused when it instead marked the task done. I understand that for a button "Mark as done" is better than "Done", but I think for a checkbox "Done" is better.
Member

Personally, I like being able to smash a button to mark a task done. A checkbox wouldn't do that feeling justice.

That sounds almost insulting to the FancyCheckbox 😆. But I understand that one gets used to finish the task via the button at that position.

If you imagine a redesign of the whole task detail I would personally start by aligning the task shown in a list with the one that title of the detail page. In the list view some additional details might be displayed via icons etc. In the Task detail we have the meta section for that. Continuing with this thought I think we should merge / align the actions and their coresponding display area. So that a usere doesn't had to jump from the action button to the meta info. By merging this we reduce visual clutter and complexity.

The latter is the same reason why I would prefer to get rid of the 'mark done' action button at its current location. I do get though that applying this change without adjusting the actions might add more harm than keeping the current state.

> Personally, I like being able to smash a button to mark a task done. A checkbox wouldn't do that feeling justice. That sounds almost insulting to the FancyCheckbox 😆. But I understand that one gets used to finish the task via the button at that position. If you imagine a redesign of the whole task detail I would personally start by aligning the task shown in a list with the one that title of the detail page. In the list view some additional details might be displayed via icons etc. In the Task detail we have the meta section for that. Continuing with this thought I think we should merge / align the actions and their coresponding display area. So that a usere doesn't had to jump from the action button to the meta info. By merging this we reduce visual clutter and complexity. The latter is the same reason why I would prefer to get rid of the 'mark done' action button at its current location. I do get though that applying this change without adjusting the actions might add more harm than keeping the current state.
Owner

Okay, but if we go with the checkbox instead of the button, we should move it to the left of the title.

I'm still not sure if this is a good idea. I feel like this would be a big change which makes the way to mark a task done less obvious.

Okay, but if we go with the checkbox instead of the button, we should move it to the left of the title. I'm still not sure if this is a good idea. I feel like this would be a big change which makes the way to mark a task done less obvious.
Member

I feel like this would be a big change which makes the way to mark a task done less obvious.

That's true. As said I think this should be part of something where we completely rethink the detail page. Opt-in might make sense in the beginning in order to gain feedback.

> I feel like this would be a big change which makes the way to mark a task done less obvious. That's true. As said I think this should be part of something where we completely rethink the detail page. Opt-in might make sense in the beginning in order to gain feedback.
Author
Contributor

makes the way to mark a task done less obvious

Less obvious to current users? Yes. Less obvious to new users? I disagree. I think besides the title is a more intuitive place.

Let's consider making this a setting, or keeping keeping the button and adding the checkbox.

> makes the way to mark a task done less obvious Less obvious to current users? Yes. Less obvious to new users? I disagree. I think besides the title is a more intuitive place. Let's consider making this a setting, or keeping keeping the button _and_ adding the checkbox.
Owner

or keeping keeping the button and adding the checkbox.

I think that could work. And then maybe remove the button once everyone knows about the checkbos.

> or keeping keeping the button and adding the checkbox. I think that could work. And then maybe remove the button once everyone knows about the checkbos.
Owner

hey @WofWca are you still interested in this?

hey @WofWca are you still interested in this?
Author
Contributor

In a sense that whether I personally need this changed - no, and not in the foreseeable future.

In a sense that whether I _personally_ need this changed - no, and not in the foreseeable future.
konrad closed this pull request 2023-10-23 08:11:55 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.