vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: list view: don't sort tasks after marking one "done" #3285

Merged
konrad merged 1 commits from WofWca/frontend:disable-list-sort-after-mark-done into main 2023-03-23 20:50:20 +00:00
Conversation 6 Commits 1 Files Changed 1 -20
WofWca commented 2023-03-23 08:39:47 +00:00
Contributor
Copy Link

See https://community.vikunja.io/t/list-view-tasks-being-sorted-after-marking-one-done-throws-you-off/1257/2

See https://community.vikunja.io/t/list-view-tasks-being-sorted-after-marking-one-done-throws-you-off/1257/2
👍 1
dpschen commented 2023-03-23 10:06:17 +00:00
Member
Copy Link

Seems legit to me. Can't think of any case where this wouldn't work. In order to test this on a preview the lint needs to pass. @WofWca Could you remove the function definition of sortTasks() as well, now that it isn't used anymore?

Seems legit to me. Can't think of any case where this wouldn't work. In order to test this on a preview the lint needs to pass. @WofWca Could you remove the function definition of `sortTasks()` as well, now that it isn't used anymore?
dpschen requested review from dpschen 2023-03-23 10:06:32 +00:00
dpschen added the
kind/bug
 label 2023-03-23 10:06:38 +00:00
WofWca force-pushed disable-list-sort-after-mark-done from 8c7ace7891 to d41143223a 2023-03-23 10:09:00 +00:00 Compare
frederick commented 2023-03-23 10:13:43 +00:00
Member
Copy Link

Hi WofWca!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3285-disable-list-sort-after-mark-don--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi WofWca! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3285-disable-list-sort-after-mark-don--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen commented 2023-03-23 10:31:25 +00:00
Member
Copy Link

Somehow the pop sound isn't played anymore when you check of the item.

Somehow the pop sound isn't played anymore when you check of the item.
WofWca commented 2023-03-23 10:42:58 +00:00
Author
Contributor
Copy Link

I tried the prev. commit. It's not played there either. Try this preview, for example:

#3278

I tried the prev. commit. It's not played there either. Try this preview, for example: https://kolaente.dev/vikunja/frontend/pulls/3278
👍 1
dpschen commented 2023-03-23 11:40:08 +00:00
Member
Copy Link

I tried the prev. commit. It's not played there either. Try this preview, for example:

#3278

You are right. The reason why it did play for me was that I changed the language once in https://try.vikunja.io (with which I compared this branch) what triggered the playSoundWhenDoneKey to be saved. That's not really optimal. We enable this automatically if you save the settings and none are set yet, because we wanted this as a default, while at the same time we didn't want to annoy users to always save this setting. Because right now no good storage exists for this kind of simple user settings it's saved in local storage…

> I tried the prev. commit. It's not played there either. Try this preview, for example: > > https://kolaente.dev/vikunja/frontend/pulls/3278 You are right. The reason why it did play for me was that I changed the language once in https://try.vikunja.io (with which I compared this branch) what triggered the `playSoundWhenDoneKey` to be saved. That's not really optimal. We enable this automatically if you save the settings and none are set yet, because we wanted this as a default, while at the same time we didn't want to annoy users to always save this setting. Because right now no good storage exists for this kind of simple user settings it's saved in local storage…
dpschen commented 2023-03-23 11:49:04 +00:00
Member
Copy Link

LGTM!

LGTM!
dpschen approved these changes 2023-03-23 11:49:14 +00:00
dpschen requested review from konrad 2023-03-23 11:49:19 +00:00
konrad was assigned by dpschen 2023-03-23 11:49:26 +00:00
konrad merged commit 6870db4a72 into main 2023-03-23 20:50:20 +00:00
konrad deleted branch disable-list-sort-after-mark-done 2023-03-23 20:50:20 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3285
No description provided.
Delete Branch "WofWca/frontend:disable-list-sort-after-mark-done"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?