Mobile Menu Fixes #332

azymondrian · 2020-12-16T03:55:48Z

azymondrian commented

2020-12-16 03:55:48 +00:00

(If I've done anything wrong process-wise please let me know)

Fixes some issues with the navigation menu on mobile

Main content squishing super narrow when menu is open
Keep main content from sliding over when menu is open (I think this could be fine, but the rest of the UI wasn't sliding so I made it match)
Close menu on first page load on mobile

(If I've done anything wrong process-wise please let me know) Fixes some issues with the navigation menu on mobile - Main content squishing super narrow when menu is open - Keep main content from sliding over when menu is open (I think this could be fine, but the rest of the UI wasn't sliding so I made it match) - Close menu on first page load on mobile

azymondrian commented

2020-12-16 05:54:33 +00:00

Hmm after realizing that I should probably run Cypress locally I can reproduce the test it's failing, but not 100% sure why what I changed would cause it to fail.

Will have to take a look tomorrow.

Hmm after realizing that I should probably run Cypress locally I can reproduce the test it's failing, but not 100% sure why what I changed would cause it to fail. Will have to take a look tomorrow.

konrad approved these changes 2020-12-16 10:36:38 +00:00

konrad left a comment

Looks great, thanks!

As for the ci failure: The CI sometimes runs a lot slower which results in random parts of tests timing out (runs on a vps after all). While not ideal, I currently have no better solution other than to add cy.wait in places where that happens until it succeeds. I've just pushed a commit to your branch which does exactly that, we'll see if it passes now.

Looks great, thanks! As for the ci failure: The CI sometimes runs a lot slower which results in random parts of tests timing out (runs on a vps after all). While not ideal, I currently have no better solution other than to add `cy.wait` in places where that happens until it succeeds. I've just pushed a commit to your branch which does exactly that, we'll see if it passes now.

konrad commented

2020-12-16 11:02:16 +00:00

So, I did some checking and found that the test is "correctly broken": It can't find the element on the "Done" button since all of the buttons are moved to the right and "pushed" outside of the screen.

Take a look at the screenshot from the CI:

In comparison, this is the task detail view for the same screen size on try:

(still not ideal but I think you get the idea)

So, I did some checking and found that the test is "correctly broken": It can't find the element on the "Done" button since all of the buttons are moved to the right and "pushed" outside of the screen. Take a look at the screenshot from the CI: ![image](/attachments/23e59b80-2176-46b5-9bfb-e0c64be9fb8c) In comparison, this is the task detail view for the same screen size on try: ![image](/attachments/e80c4a07-503e-498b-8510-ebe198ea31d9) (still not ideal but I think you get the idea)

image.png

177 KiB

image.png

177 KiB

image.png

109 KiB