Show task progress on task #354

Merged
konrad merged 5 commits from azymondrian/vikunja-frontend:show-progress into master 2020-12-31 15:16:08 +00:00
Contributor

I'm not sure if you guys want this, but I implemented it for myself and figured I'd see.

Shows the task completion percent as progress bar in task lists and on kanban cards.

I'm not sure if you guys want this, but I implemented it for myself and figured I'd see. Shows the task completion percent as progress bar in task lists and on kanban cards.
Author
Contributor

The same test is failing locally for me too, have not figured out why...

The same test is failing locally for me too, have not figured out why...
konrad requested changes 2020-12-28 22:13:31 +00:00
konrad left a comment
Owner

Could you put the progress bar next to the other task properties so that everything is in one like? Maybe only on mobile underneath?

Could you put the progress bar next to the other task properties so that everything is in one like? Maybe only on mobile underneath?
Owner

The test failure doesn't really make sense - I've restarted the build to see if that "fixes" it.

The test failure doesn't really make sense - I've restarted the build to see if that "fixes" it.
Owner

Looks like the test failing here fails everywhere, just not on master.

Looks like the test failing here fails everywhere, just not on master.
Owner

Found the issue and fixed it in ddd24825a3

Found the issue and fixed it in https://drone.kolaente.de/link/vikunja/frontend/commit/ddd24825a32a2a646f126212071c4b56fa751131
Author
Contributor

Ah that's a good idea! I'll definitely update that

Ah that's a good idea! I'll definitely update that
azymondrian force-pushed show-progress from 083d71cf4f to 210ef19c43 2020-12-29 17:22:10 +00:00 Compare
Author
Contributor

I think this looks good to me, but there's a lot of tweaking that can be done depending on how you want the progress bar to shrink.

I think this looks good to me, but there's a lot of tweaking that can be done depending on how you want the progress bar to shrink.
azymondrian requested review from konrad 2020-12-29 17:31:42 +00:00
Contributor

I tried it out, and it looks nice, but #358 seems to have broken it.
It should work if you change flex: 1 0 xxx to flex: 0 0 xxx on .color-bubble class, in tasks.scss and navigation.scss.

image

I tried it out, and it looks nice, but #358 seems to have broken it. It should work if you change `flex: 1 0 xxx` to `flex: 0 0 xxx` on `.color-bubble` class, in `tasks.scss` and `navigation.scss`. ![image](/attachments/c7159050-0b0d-480f-9340-de2ab09c6ac5)
Author
Contributor

Good catch, I hadn't turned on many colors yet. I'll work on that

Good catch, I hadn't turned on many colors yet. I'll work on that
Owner

Looks good so far, I think the progressbar could take up the full width on kanban as it already does that on mobile kanban:

image

instead of
image

I'd also make it a bit smaller on the kanban board.

Looks good so far, I think the progressbar could take up the full width on kanban as it already does that on mobile kanban: ![image](/attachments/22cac8c8-c498-46d7-83c6-886652fa5716) instead of ![image](/attachments/6e94a447-9e82-46f5-9cc6-e0269ed90dda) I'd also make it a bit smaller on the kanban board.
Author
Contributor

Shoot that's a regression, I forgot to double check how that last commit affected the kanban cards.

How much smaller are you thinking? I think 0.6 rem looks reasonably smaller without looking too small?

Shoot that's a regression, I forgot to double check how that last commit affected the kanban cards. How much smaller are you thinking? I think 0.6 rem looks reasonably smaller without looking too small?
Owner

I think .5rem would look good:

image

It currently is at .75rem

I think `.5rem` would look good: ![image](/attachments/0018281d-4633-4399-a286-618b4fa0dad1) It currently is at `.75rem`
azymondrian force-pushed show-progress from 210ef19c43 to b03fbdd297 2020-12-31 00:59:06 +00:00 Compare
Author
Contributor

I think I've covered everything 🤞

Fixed the color bubbles stretching and fixed the kanban regressions and made it .5rem tall

I think I've covered everything 🤞 Fixed the color bubbles stretching and fixed the kanban regressions and made it `.5rem` tall
konrad approved these changes 2020-12-31 15:15:53 +00:00
konrad left a comment
Owner

Thanks again!

Thanks again!
konrad merged commit 158e697988 into master 2020-12-31 15:16:08 +00:00
azymondrian deleted branch show-progress 2020-12-31 17:38:02 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.