Show task progress on task #354
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#354
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "azymondrian/vikunja-frontend:show-progress"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I'm not sure if you guys want this, but I implemented it for myself and figured I'd see.
Shows the task completion percent as progress bar in task lists and on kanban cards.
The same test is failing locally for me too, have not figured out why...
Could you put the progress bar next to the other task properties so that everything is in one like? Maybe only on mobile underneath?
The test failure doesn't really make sense - I've restarted the build to see if that "fixes" it.
Looks like the test failing here fails everywhere, just not on master.
Found the issue and fixed it in
ddd24825a3
Ah that's a good idea! I'll definitely update that
083d71cf4f
to210ef19c43
I think this looks good to me, but there's a lot of tweaking that can be done depending on how you want the progress bar to shrink.
I tried it out, and it looks nice, but #358 seems to have broken it.
It should work if you change
flex: 1 0 xxx
toflex: 0 0 xxx
on.color-bubble
class, intasks.scss
andnavigation.scss
.Good catch, I hadn't turned on many colors yet. I'll work on that
Looks good so far, I think the progressbar could take up the full width on kanban as it already does that on mobile kanban:
instead of
I'd also make it a bit smaller on the kanban board.
Shoot that's a regression, I forgot to double check how that last commit affected the kanban cards.
How much smaller are you thinking? I think 0.6 rem looks reasonably smaller without looking too small?
I think
.5rem
would look good:It currently is at
.75rem
210ef19c43
tob03fbdd297
I think I've covered everything 🤞
Fixed the color bubbles stretching and fixed the kanban regressions and made it
.5rem
tallThanks again!