Add "new label" button to label management #359

Merged
konrad merged 2 commits from profi248/frontend:new-label-button into master 2020-12-30 17:55:54 +00:00
Contributor

Allow to create labels directly from Manage labels page. It uses the same fullscreen dialog style as adding other things.

Almost all of the code is reused the NewTeam component

Allow to create labels directly from Manage labels page. It uses the same fullscreen dialog style as adding other things. Almost all of the code is reused the `NewTeam` component
profi248 added 1 commit 2020-12-29 15:23:47 +00:00
Add "new label" button to label management
All checks were successful
continuous-integration/drone/pr Build is passing
4214ab3c92
konrad requested changes 2020-12-30 16:45:35 +00:00
konrad left a comment
Owner

Looks great so far, just some small nits.

Looks great so far, just some small nits.
@ -0,0 +1,84 @@
<template>
<div class="fullpage">
<a @click="back()" class="close">
<icon :icon="['far', 'times-circle']">

Please use <icon :icon="['far', 'times-circle']"/> instead

Please use `<icon :icon="['far', 'times-circle']"/>` instead
konrad marked this conversation as resolved
@ -0,0 +11,4 @@
<input
:class="{ 'disabled': labelService.loading }"
class="input"
placeholder="The label name goes here..." type="text"

Labels actually don't have names, only titles 🙂 Could you update that here and in the error message?

Labels actually don't have names, only titles 🙂 Could you update that here and in the error message?
konrad marked this conversation as resolved
@ -0,0 +65,4 @@
}
this.showError = false
console.log(this.label);

Could you remove this?

Could you remove this?
Author
Contributor

oops, sorry about that

oops, sorry about that
konrad marked this conversation as resolved
@ -0,0 +69,4 @@
this.labelService.create(this.label)
.then(response => {
router.push({name: 'labels.index', params: {id: response.id}})

Please use this.$router

Please use `this.$router`
konrad marked this conversation as resolved
@ -0,0 +77,4 @@
})
},
back() {
router.go(-1)

Please use this.$router

Please use `this.$router`
konrad marked this conversation as resolved
profi248 added 1 commit 2020-12-30 17:45:38 +00:00
name -> title, cleanup
All checks were successful
continuous-integration/drone/pr Build is passing
0506cc8726
Author
Contributor

I pushed an update, everything should be resolved

I pushed an update, everything should be resolved
konrad approved these changes 2020-12-30 17:54:53 +00:00
konrad left a comment
Owner

Thanks!

Thanks!
konrad merged commit 60c21cc36a into master 2020-12-30 17:55:54 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.