Add "new label" button to label management #359
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#359
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "profi248/frontend:new-label-button"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Allow to create labels directly from Manage labels page. It uses the same fullscreen dialog style as adding other things.
Almost all of the code is reused the
NewTeam
componentLooks great so far, just some small nits.
@ -0,0 +1,84 @@
<template>
<div class="fullpage">
<a @click="back()" class="close">
<icon :icon="['far', 'times-circle']">
Please use
<icon :icon="['far', 'times-circle']"/>
instead@ -0,0 +11,4 @@
<input
:class="{ 'disabled': labelService.loading }"
class="input"
placeholder="The label name goes here..." type="text"
Labels actually don't have names, only titles 🙂 Could you update that here and in the error message?
@ -0,0 +65,4 @@
}
this.showError = false
console.log(this.label);
Could you remove this?
oops, sorry about that
@ -0,0 +69,4 @@
this.labelService.create(this.label)
.then(response => {
router.push({name: 'labels.index', params: {id: response.id}})
Please use
this.$router
@ -0,0 +77,4 @@
})
},
back() {
router.go(-1)
Please use
this.$router
I pushed an update, everything should be resolved
Thanks!