vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Improve editor buttons UX #361

Merged
konrad merged 3 commits from profi248/frontend:edit-button into master 2020-12-30 21:52:44 +00:00
Conversation 10 Commits 3 Files Changed 2 +4 -4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c16c454f36 - Show all commits

8
src/components/input/editor.vue
View File

@ -2,7 +2,7 @@
<div :class="{'is-pulled-up': isEditEnabled}" class="editor">
<div class="tabs is-right" v-if="hasPreview && isEditEnabled && !hasEditBottom">
<ul>
<li :class="{'is-active': isEditActive}">
<li>
konrad commented 2020-12-30 19:59:10 +00:00
Outdated
Review
Copy Link

I think we can also remove this since there's only ever one item now - that way all of them have the same "visual hierachy"

I think we can also remove this since there's only ever one item now - that way all of them have the same "visual hierachy"
<a v-if="!isEditActive" @click="toggleEdit">Edit</a>
<a v-else @click="toggleEdit">Done</a>
</li>
@ -22,9 +22,9 @@
<ul class="actions">
<template v-if="hasEditBottom">
<li :class="{'is-active': isEditActive}">
<li>
<a v-if="!isEditActive" @click="toggleEdit">Edit</a>
<a v-else @click="toggleEdit">Save</a>
<a v-else @click="toggleEdit">Done</a>
konrad commented 2020-12-30 19:54:08 +00:00
Outdated
Review
Copy Link

I think this should say "Done" as well to be consistent with the rest.

I think this should say "Done" as well to be consistent with the rest.
</li>
</template>
<li v-for="(action, k) in bottomActions" :key="k">
@ -395,7 +395,7 @@ export default {
this.isPreviewActive = true;
this.isEditActive = false;
this.renderPreview();
this.$emit('change');
this.bubble(0); // save instantly
konrad commented 2020-12-30 19:55:51 +00:00
Outdated
Review
Copy Link

Please use this.bubble().

Please use `this.bubble()`.
} else {
this.isPreviewActive = false;
this.isEditActive = true;