vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Improve some translations #581

Merged
konrad merged 3 commits from :main into main 2021-07-09 08:22:21 +00:00
Conversation 6 Commits 3 Files Changed 14 +61 -19
andreymal commented 2021-07-08 13:44:34 +00:00
Contributor
Copy Link

There are three commits:

  • fixing some typos;
  • fixing some missing translations;
  • making titles of pseudo namespaces and pseudo lists translatable, while the backend doesn't support translations yet.

The last commit was the most problematic for me, since I'm not a Vue expert. If there is a more idiomatic way to implement this, I'm ready to rewrite it. But at least it works :)

P.S. Any plans to merge the main branch with Weblate? It has no new translation strings added recently (quick magic etc.)
P.P.S. The "Frontend BROKEN, DO NOT USE" component generates a lot of false-positive checks on Weblate.
P.P.P.S. Not sure if there is a way to properly integrate the EasyMDE strings with vue-i18n...

There are three commits: - fixing some typos; - fixing some missing translations; - making titles of pseudo namespaces and pseudo lists translatable, while the backend doesn't support translations yet. The last commit was the most problematic for me, since I'm not a Vue expert. If there is a more idiomatic way to implement this, I'm ready to rewrite it. But at least it works :) P.S. Any plans to merge the main branch with Weblate? It has no new translation strings added recently (quick magic etc.) P.P.S. The "Frontend BROKEN, DO NOT USE" component generates a lot of false-positive checks on Weblate. P.P.P.S. Not sure if there is a way to properly integrate [the EasyMDE strings](https://github.com/Ionaru/easy-markdown-editor/blob/f52f9807a228789265d58192288fe085bfe4ecc0/src/js/easymde.js#L1626-L1649) with vue-i18n...
andreymal added 2 commits 2021-07-08 13:44:35 +00:00
andreymal force-pushed main from dc684bf2ea to 6412849cb3 2021-07-08 14:51:31 +00:00 Compare
andreymal commented 2021-07-08 15:04:56 +00:00
Author
Contributor
Copy Link

(I don't know why this test is failing)

(I don't know why this test is failing)
konrad commented 2021-07-09 07:41:06 +00:00
Owner
Copy Link

That's a date test and it fails when running at some time 🙃 I need to figure out a way to mock the time in it...

That's a date test and it fails when running at some time 🙃 I need to figure out a way to mock the time in it...
konrad approved these changes 2021-07-09 08:21:32 +00:00
konrad commented 2021-07-09 08:21:42 +00:00
Owner
Copy Link

Fixes #583

Fixes #583
konrad merged commit 7355204d2f into main 2021-07-09 08:22:21 +00:00
konrad commented 2021-07-09 08:22:27 +00:00
Owner
Copy Link

Thanks!

Thanks!
konrad commented 2021-07-09 08:23:38 +00:00
Owner
Copy Link

The "Frontend BROKEN, DO NOT USE" component generates a lot of false-positive checks on Weblate.

I noticed that too. Since I'm not very happy overall with weblate I'll probably move the translations somewhere else anyway...

> The "Frontend BROKEN, DO NOT USE" component generates a lot of false-positive checks on Weblate. I noticed that too. Since I'm not very happy overall with weblate I'll probably move the translations somewhere else anyway...
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
konrad
Labels
Clear labels
area/internal-code
changes requested
confirmed
dependencies
duplicate
This issue or pull request already exists
good first issue
help wanted
Need some help
hosting
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dpschen frederick konrad renovate
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/frontend#581
No description provided.
Delete Branch ":main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?