Improve some translations #581

andreymal · 2021-07-08T13:44:34Z

andreymal commented

2021-07-08 13:44:34 +00:00

There are three commits:

fixing some typos;
fixing some missing translations;
making titles of pseudo namespaces and pseudo lists translatable, while the backend doesn't support translations yet.

The last commit was the most problematic for me, since I'm not a Vue expert. If there is a more idiomatic way to implement this, I'm ready to rewrite it. But at least it works :)

P.S. Any plans to merge the main branch with Weblate? It has no new translation strings added recently (quick magic etc.)
P.P.S. The "Frontend BROKEN, DO NOT USE" component generates a lot of false-positive checks on Weblate.
P.P.P.S. Not sure if there is a way to properly integrate the EasyMDE strings with vue-i18n...

There are three commits: - fixing some typos; - fixing some missing translations; - making titles of pseudo namespaces and pseudo lists translatable, while the backend doesn't support translations yet. The last commit was the most problematic for me, since I'm not a Vue expert. If there is a more idiomatic way to implement this, I'm ready to rewrite it. But at least it works :) P.S. Any plans to merge the main branch with Weblate? It has no new translation strings added recently (quick magic etc.) P.P.S. The "Frontend BROKEN, DO NOT USE" component generates a lot of false-positive checks on Weblate. P.P.P.S. Not sure if there is a way to properly integrate [the EasyMDE strings](https://github.com/Ionaru/easy-markdown-editor/blob/f52f9807a228789265d58192288fe085bfe4ecc0/src/js/easymde.js#L1626-L1649) with vue-i18n...

andreymal added 2 commits 2021-07-08 13:44:35 +00:00

6ddd775530

Fix typos in translation keys

caa2fda2a4

Add missing translations for the editor buttons and the notifications title

andreymal force-pushed main from dc684bf2ea to 6412849cb3

2021-07-08 14:51:31 +00:00

Compare

andreymal commented

2021-07-08 15:04:56 +00:00

(I don't know why this test is failing)

konrad commented

2021-07-09 07:41:06 +00:00

That's a date test and it fails when running at some time 🙃 I need to figure out a way to mock the time in it...

konrad approved these changes 2021-07-09 08:21:32 +00:00

konrad commented

2021-07-09 08:21:42 +00:00

Fixes #583

konrad merged commit 7355204d2f into main

2021-07-09 08:22:21 +00:00

konrad referenced this issue from a commit

2021-07-09 08:22:21 +00:00

Improve some translations (#581)

konrad commented

2021-07-09 08:22:27 +00:00

Thanks!

konrad referenced this pull request

2021-07-09 08:22:49 +00:00

Localisation not showing #1802

konrad commented

2021-07-09 08:23:38 +00:00

The "Frontend BROKEN, DO NOT USE" component generates a lot of false-positive checks on Weblate.

I noticed that too. Since I'm not very happy overall with weblate I'll probably move the translations somewhere else anyway...

> The "Frontend BROKEN, DO NOT USE" component generates a lot of false-positive checks on Weblate. I noticed that too. Since I'm not very happy overall with weblate I'll probably move the translations somewhere else anyway...

This repo is archived. You cannot comment on pull requests.

No reviewers