vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/remove-attachment-upload-mixin #724

Merged
konrad merged 1 commits from dpschen/frontend:feature/remove-attachment-upload-mixin into main 2021-09-24 18:16:38 +00:00
Conversation 1 Commits 1 Files Changed 7 +54 -59
dpschen commented 2021-09-08 17:40:03 +00:00
Member
Copy Link

This depends on #717.
Until this is merged you can see the diff best here:
https://kolaente.dev/dpschen/frontend/compare/feature/vue3-preparation...dpschen/frontend:feature/remove-attachment-upload-mixin

EDIT:: I removed the necessity to merge the vue3-preparation branch.

Removing the mixin is one further step in direction of vue3, since mixins are considered harmful (also see Evan You's take on mixins)

~~This depends on https://kolaente.dev/vikunja/frontend/pulls/717. Until this is merged you can see the diff best here: https://kolaente.dev/dpschen/frontend/compare/feature/vue3-preparation...dpschen/frontend:feature/remove-attachment-upload-mixin~~ **EDIT:**: I removed the necessity to merge the vue3-preparation branch. Removing the mixin is one further step in direction of vue3, since [mixins are considered harmful](https://css-tricks.com/how-the-vue-composition-api-replaces-vue-mixins/#mixins-are-considered-harmful) (also see [Evan You's take on mixins](https://twitter.com/youyuxi/status/1057262906084073473))
dpschen force-pushed feature/remove-attachment-upload-mixin from ed0d8e8b22 to 91ebfa5e89 2021-09-08 23:43:34 +00:00 Compare
dpschen force-pushed feature/remove-attachment-upload-mixin from 91ebfa5e89 to 503a25b7c5 2021-09-10 18:45:17 +00:00 Compare
dpschen changed title from WIP: feature/remove-attachment-upload-mixin to feature/remove-attachment-upload-mixin 2021-09-19 15:18:31 +00:00
dpschen force-pushed feature/remove-attachment-upload-mixin from 503a25b7c5 to 09304b7fe7 2021-09-22 19:15:18 +00:00 Compare
dpschen changed title from feature/remove-attachment-upload-mixin to wip: feature/remove-attachment-upload-mixin 2021-09-22 19:15:38 +00:00
konrad approved these changes 2021-09-24 18:13:20 +00:00
konrad left a comment
Owner

Looks great! Any reason this is still wip?

Looks great! Any reason this is still wip?
dpschen changed title from wip: feature/remove-attachment-upload-mixin to feature/remove-attachment-upload-mixin 2021-09-24 18:15:53 +00:00
dpschen commented 2021-09-24 18:16:06 +00:00
Author
Member
Copy Link

Pipeline wasn't run through :)

Pipeline wasn't run through :)
👍 1
konrad merged commit 41331c8a86 into main 2021-09-24 18:16:38 +00:00
konrad deleted branch feature/remove-attachment-upload-mixin 2021-09-24 18:16:38 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#724
No description provided.
Delete Branch "dpschen/frontend:feature/remove-attachment-upload-mixin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?