vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: reduce file size by removing by removing fonts #759

Merged
konrad merged 2 commits from dpschen/frontend:feature/reduce-file-size-by-removing-font-weights into main 2021-09-23 14:07:09 +00:00
Conversation 6 Commits 2 Files Changed 2 -9
dpschen commented 2021-09-17 10:21:10 +00:00
Member
Copy Link

The fonts were either not used at all (300) or used so rarely that it makes sense to replace them by other weights (500).

The navigation still looks good.

For the future it might make sense to use variable fonts instead. Then the 500 weight could be used again without a size impact.
Both fonts do exist in a variable editon:

EDIT: See #778

The fonts were either not used at all (300) ~~or used so rarely that it makes sense to replace them by other weights (500).~~ ~~The navigation still looks good.~~ For the future it might make sense to use variable fonts instead. Then the 500 weight could be used again without a size impact. Both fonts do exist in a variable editon: - https://github.com/googlefonts/opensans/tree/main/fonts/variable - https://github.com/andrew-paglinawan/QuicksandFamily/blob/master/fonts/Quicksand%5Bwght%5D.ttf **EDIT:** See https://kolaente.dev/vikunja/frontend/issues/778
konrad commented 2021-09-21 16:52:12 +00:00
Owner
Copy Link

I'm not quite conviced. What's bothering me is that the font weight is not the same for menu items and lists/filters:

image

And it looks like the font used for list in the menu is not Open Sans anymore but some random font from my system? That might be an issue with the bulma variables though. EDIT: Yup, bulma issue. Updated the branch and it looks fine, nevermind the noise.

I'm not quite conviced. What's bothering me is that the font weight is not the same for menu items and lists/filters: ![image](/attachments/becd9272-7f0e-4aa0-9683-76a69bec543d) ~~And it looks like the font used for list in the menu is not Open Sans anymore but some random font from my system? That might be an issue with the bulma variables though.~~ **EDIT**: Yup, bulma issue. Updated the branch and it looks fine, nevermind the noise.
image.png
18 KiB
konrad added the
changes requested
 label 2021-09-21 19:09:11 +00:00
dpschen commented 2021-09-21 19:27:13 +00:00
Author
Member
Copy Link

EDIT: Yup, bulma issue. Updated the branch and it looks fine, nevermind the noise.

Okay :) Not sure what I should change then.

> EDIT: Yup, bulma issue. Updated the branch and it looks fine, nevermind the noise. Okay :) Not sure what I should change then.
konrad commented 2021-09-21 19:42:24 +00:00
Owner
Copy Link

What's bothering me is that the font weight is not the same for menu items and lists/filters

This is still an issue - the bulma thing was about using a different font being used in the lists.

> What's bothering me is that the font weight is not the same for menu items and lists/filters This is still an issue - the bulma thing was about using a different font being used in the lists.
dpschen commented 2021-09-22 18:42:53 +00:00
Author
Member
Copy Link

What's bothering me is that the font weight is not the same for menu items and lists/filters

This is still an issue - the bulma thing was about using a different font being used in the lists.

Okay. Maybe let's remove just the 300 for now (can't find any reference) and keep the 500. I agree that it looks better. I think I was just overoptimizing here :D

I will open a (not very important but interesting) issue for the variable fonts.

> > What's bothering me is that the font weight is not the same for menu items and lists/filters > > This is still an issue - the bulma thing was about using a different font being used in the lists. Okay. Maybe let's remove just the 300 for now (can't find any reference) and keep the 500. I agree that it looks better. I think I was just overoptimizing here :D I will open a (not very important but interesting) issue for the variable fonts.
dpschen force-pushed feature/reduce-file-size-by-removing-font-weights from 5757c111b7 to 631ad0b446 2021-09-22 18:53:52 +00:00 Compare
dpschen force-pushed feature/reduce-file-size-by-removing-font-weights from 631ad0b446 to 89fd09aa92 2021-09-22 18:55:29 +00:00 Compare
dpschen added 1 commit 2021-09-22 21:36:51 +00:00
dpschen commented 2021-09-23 11:30:03 +00:00
Author
Member
Copy Link

@konrad not sure why the pipeline fails.
Now I'm just removing that one font file and it's import.

@konrad not sure why the pipeline fails. Now I'm just removing that one font file and it's import.
konrad commented 2021-09-23 14:06:13 +00:00
Owner
Copy Link

Restarted the build, seems to pass now.

Restarted the build, seems to pass now.
konrad merged commit 6b1bf27bf8 into main 2021-09-23 14:07:09 +00:00
konrad deleted branch feature/reduce-file-size-by-removing-font-weights 2021-09-23 14:07:09 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#759
No description provided.
Delete Branch "dpschen/frontend:feature/reduce-file-size-by-removing-font-weights"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?