feat: use recommended linting settings for vue #930

Merged
konrad merged 2 commits from dpschen/frontend:feature/use-recommended-vue-linting into main 2024-02-07 12:23:12 +00:00
Member

I didn't apply the fixes by intend.

First run I get 8235 warnings
After fixing: 98 warnings
After fixing again: 74 warnings

The remaing warnings seem to be mostly about:

  • prop validation (defining types) like: Prop "foobar" should define at least its type
  • The "computed" property should be above the "watch" property

I think these warnings don't need to be done immediately. We could also disable them for now.

After fixing this maybe we can integrate Prettier


Applying these fixes should be carefully timed—we don't want any larger pull-request to be open at that time.

I didn't apply the fixes by intend. First run I get 8235 warnings After fixing: 98 warnings After fixing again: 74 warnings The remaing warnings seem to be mostly about: - prop validation (defining types) like: `Prop "foobar" should define at least its type` - `The "computed" property should be above the "watch" property` I think these warnings don't need to be done immediately. We could also disable them for now. After fixing this maybe we can [integrate Prettier](https://eslint.vuejs.org/user-guide/#faq) --- Applying these fixes should be carefully timed—we don't want any larger pull-request to be open at that time.
dpschen added the
kind/feature
label 2021-11-01 14:18:24 +00:00
dpschen force-pushed feature/use-recommended-vue-linting from 67eaaab8de to 5061627d16 2021-11-01 14:25:07 +00:00 Compare
Owner

I think this would be a good addition.

Maybe we can combine this with #913 ?

I think this would be a good addition. Maybe we can combine this with https://kolaente.dev/vikunja/frontend/pulls/913 ?
Author
Member

I think this would be a good addition.

Maybe we can combine this with #913 ?

That makes sense! =)

we don't want any larger pull-request to be open at that time.

Right now this is blocked for me either way :D
I still have a lot of stuff just locally that is not even suitable for wip branches.

> I think this would be a good addition. > > Maybe we can combine this with https://kolaente.dev/vikunja/frontend/pulls/913 ? That makes sense! =) > we don't want any larger pull-request to be open at that time. Right now this is blocked for me either way :D I still have a lot of stuff just locally that is not even suitable for wip branches.
Author
Member

Note:
we decided we'll wait for #899 and #816 + the other open pull requests for this to merge.

Note: we decided we'll wait for https://kolaente.dev/vikunja/frontend/pulls/899 and https://kolaente.dev/vikunja/frontend/pulls/816 + the other open pull requests for this to merge.
dpschen force-pushed feature/use-recommended-vue-linting from 5061627d16 to 5f20c7fc91 2022-02-05 18:16:47 +00:00 Compare
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://930-featureuse-recommended-vue-linting--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://930-featureuse-recommended-vue-linting--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen changed title from WIP: feat: use recommended linting settings for vue to feat: use recommended linting settings for vue 2022-02-14 22:52:28 +00:00
konrad approved these changes 2022-02-18 19:55:06 +00:00
konrad left a comment
Owner

CI passes so we are good?

Please rebase, you can merge once the CI passes.

CI passes so we are good? Please rebase, you can merge once the CI passes.
Author
Member

I'm a bit confused that this passes?

A lot of fixes would need to happen before this works. See the initial comment.

I'm a bit confused that this passes? A lot of fixes would need to happen before this works. See the initial comment.
Owner

Maybe the refactoring we did in the meantime already fixed stuff?

Maybe the refactoring we did in the meantime already fixed stuff?
konrad reviewed 2022-02-20 16:40:31 +00:00
package.json Outdated
@ -11,6 +11,7 @@
"build:dev": "vite build -m development --outDir dist-dev/",
"typecheck": "vue-tsc --noEmit",
"lint": "eslint --ignore-pattern '*.test.*' ./src --ext .vue,.js,.ts",
"lint:fix": "eslint --ignore-pattern '*.test.*' ./src --ext .vue,.js,.ts --fix",

Maybe this could be something like

"lint:fix": "yarn lint --fix",

That way we wouldn't need to duplicate the options, but I'm not sure if this would even work if if there's a better way to do this.

Maybe this could be something like ``` "lint:fix": "yarn lint --fix", ``` That way we wouldn't need to duplicate the options, but I'm not sure if this would even work if if there's a better way to do this.
Author
Member

Good idea!

I think it's possible to write lint --fix. Then it's independant of the package manager (e.g. in case we change it). Will check.

Good idea! I think it's possible to write `lint --fix`. Then it's independant of the package manager (e.g. in case we change it). Will check.
dpschen force-pushed feature/use-recommended-vue-linting from 9e9cc2d088 to 6bea90792f 2023-02-27 15:55:51 +00:00 Compare
dpschen force-pushed feature/use-recommended-vue-linting from 6bea90792f to 4d0e62cf67 2023-03-17 15:53:10 +00:00 Compare
Owner

https://rome.tools/ looks interesting as well

https://rome.tools/ looks interesting as well
Author
Member

https://rome.tools/ looks interesting as well

Rome sounds like a good idea to follow longterm, afaik it's still not so good for day to day (?)

> https://rome.tools/ looks interesting as well Rome sounds like a good idea to follow longterm, afaik it's still not so good for day to day (?)
konrad force-pushed feature/use-recommended-vue-linting from 4d0e62cf67 to fc1dc55186 2024-02-07 10:56:30 +00:00 Compare
konrad added 2 commits 2024-02-07 11:41:15 +00:00
konrad force-pushed feature/use-recommended-vue-linting from d918736d9b to 3998745c92 2024-02-07 11:44:39 +00:00 Compare
konrad scheduled this pull request to auto merge when all checks succeed 2024-02-07 11:46:35 +00:00
konrad approved these changes 2024-02-07 11:47:39 +00:00
konrad force-pushed feature/use-recommended-vue-linting from 3998745c92 to f27454c929 2024-02-07 11:51:23 +00:00 Compare
konrad force-pushed feature/use-recommended-vue-linting from f27454c929 to 6966708931 2024-02-07 12:03:16 +00:00 Compare
konrad merged commit 447641c222 into main 2024-02-07 12:23:12 +00:00
konrad deleted branch feature/use-recommended-vue-linting 2024-02-07 12:23:33 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.