feat: use recommended linting settings for vue #930
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#930
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/use-recommended-vue-linting"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I didn't apply the fixes by intend.
First run I get 8235 warnings
After fixing: 98 warnings
After fixing again: 74 warnings
The remaing warnings seem to be mostly about:
Prop "foobar" should define at least its type
The "computed" property should be above the "watch" property
I think these warnings don't need to be done immediately. We could also disable them for now.
After fixing this maybe we can integrate Prettier
Applying these fixes should be carefully timed—we don't want any larger pull-request to be open at that time.
67eaaab8de
to5061627d16
I think this would be a good addition.
Maybe we can combine this with #913 ?
That makes sense! =)
Right now this is blocked for me either way :D
I still have a lot of stuff just locally that is not even suitable for wip branches.
Note:
we decided we'll wait for #899 and #816 + the other open pull requests for this to merge.
5061627d16
to5f20c7fc91
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://930-featureuse-recommended-vue-linting--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
WIP: feat: use recommended linting settings for vueto feat: use recommended linting settings for vueCI passes so we are good?
Please rebase, you can merge once the CI passes.
I'm a bit confused that this passes?
A lot of fixes would need to happen before this works. See the initial comment.
Maybe the refactoring we did in the meantime already fixed stuff?
@ -11,6 +11,7 @@
"build:dev": "vite build -m development --outDir dist-dev/",
"typecheck": "vue-tsc --noEmit",
"lint": "eslint --ignore-pattern '*.test.*' ./src --ext .vue,.js,.ts",
"lint:fix": "eslint --ignore-pattern '*.test.*' ./src --ext .vue,.js,.ts --fix",
Maybe this could be something like
That way we wouldn't need to duplicate the options, but I'm not sure if this would even work if if there's a better way to do this.
Good idea!
I think it's possible to write
lint --fix
. Then it's independant of the package manager (e.g. in case we change it). Will check.9e9cc2d088
to6bea90792f
6bea90792f
to4d0e62cf67
https://rome.tools/ looks interesting as well
Rome sounds like a good idea to follow longterm, afaik it's still not so good for day to day (?)
4d0e62cf67
tofc1dc55186
d918736d9b
to3998745c92
3998745c92
tof27454c929
f27454c929
to6966708931