vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: add preview deploys with netlify #972

Merged
konrad merged 7 commits from feature/netlify-preview into main 2021-11-10 21:25:50 +00:00
Conversation 11 Commits 7 Files Changed 6 +6093 -109
konrad commented 2021-11-10 19:42:07 +00:00
Owner
Copy Link
No description provided.
konrad added 1 commit 2021-11-10 19:42:07 +00:00
feat: add preview deploys with netlify
Some checks failed
continuous-integration/drone/pr Build is failing
Details
d894f6c3c9
konrad added 1 commit 2021-11-10 19:47:20 +00:00
fix: netlify cli path
Some checks failed
continuous-integration/drone/pr Build is failing
Details
90763104ca
konrad added 1 commit 2021-11-10 19:51:22 +00:00
fix: netlify link
All checks were successful
continuous-integration/drone/pr Build is passing
Details
2b57987824
konrad added 1 commit 2021-11-10 20:03:33 +00:00
ci: debug env
All checks were successful
continuous-integration/drone/pr Build is passing
Details
10389c492e
dpschen commented 2021-11-10 20:16:44 +00:00
Member
Copy Link

Sweet!

Sweet!
konrad added 1 commit 2021-11-10 20:38:39 +00:00
feat: add deploy script
All checks were successful
continuous-integration/drone/pr Build is passing
Details
0dd9a26926
konrad commented 2021-11-10 20:41:20 +00:00
Author
Owner
Copy Link

Now I just need to figure out a way to prevent the bot from adding more than one comment...

Now I just need to figure out a way to prevent the bot from adding more than one comment...
konrad added 2 commits 2021-11-10 20:51:09 +00:00
feat: send only one comment
All checks were successful
continuous-integration/drone/pr Build is passing
Details
17c0b1f68f
frederick commented 2021-11-10 20:55:57 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://972-featurenetlify-preview--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://972-featurenetlify-preview--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad changed title from feat: add preview deploys with netlify to WIP: feat: add preview deploys with netlify 2021-11-10 20:57:04 +00:00
konrad changed title from WIP: feat: add preview deploys with netlify to feat: add preview deploys with netlify 2021-11-10 20:57:09 +00:00
konrad requested review from dpschen 2021-11-10 20:57:28 +00:00
konrad commented 2021-11-10 20:57:55 +00:00
Author
Owner
Copy Link

This seems to work like it should now. @dpschen Anything to add?

This seems to work like it should now. @dpschen Anything to add?
dpschen commented 2021-11-10 21:01:06 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://972-featurenetlify-preview--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hey frederick 👋
You seem to be nice ;)

> > Hi konrad! > > Thank you for creating a PR! > > I've deployed the changes of this PR on a preview environment under this URL: https://972-featurenetlify-preview--vikunja-frontend-preview.netlify.app > > You can use this url to view the changes live and test them out. > You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. > > Have a nice day! > > > Beep boop, I'm a bot. > Hey frederick 👋 You seem to be nice ;)
konrad commented 2021-11-10 21:04:25 +00:00
Author
Owner
Copy Link

Hey frederick 👋
You seem to be nice ;)

There's quite a few hints about him in various other places already 😀

> Hey frederick 👋 You seem to be nice ;) There's quite a few hints about him in various other places already 😀
😆 1
dpschen commented 2021-11-10 21:22:30 +00:00
Member
Copy Link

This seems to work like it should now. @dpschen Anything to add?

The api seems to be set wrong. Everything else: really cool =)

> This seems to work like it should now. @dpschen Anything to add? The api seems to be set wrong. Everything else: really cool =)
konrad commented 2021-11-10 21:25:38 +00:00
Author
Owner
Copy Link

The api seems to be set wrong. Everything else: really cool =)

Ohh right. Yeah I think that comes from the built bundle that's deployed. Will go away once #926 is merged.

> The api seems to be set wrong. Everything else: really cool =) Ohh right. Yeah I think that comes from the built bundle that's deployed. Will go away once #926 is merged.
👍 1
konrad merged commit e49fd16a3a into main 2021-11-10 21:25:50 +00:00
konrad deleted branch feature/netlify-preview 2021-11-10 21:25:50 +00:00
konrad commented 2021-11-10 21:30:48 +00:00
Author
Owner
Copy Link

And it does seem to work: image

And it does seem to work: ![image](/attachments/14a43061-e3a7-4f88-afad-390c5d8178c5)
image.png
35 KiB
dpschen refused to review 2021-11-10 21:33:19 +00:00
dpschen commented 2021-11-11 21:54:49 +00:00
Member
Copy Link

@konrad:

Deep links seem to be broken:

https://972-featurenetlify-preview--vikunja-frontend-preview.netlify.app/tasks/by/upcoming

@konrad: Deep links seem to be broken: https://972-featurenetlify-preview--vikunja-frontend-preview.netlify.app/tasks/by/upcoming
konrad commented 2021-11-12 06:57:07 +00:00
Author
Owner
Copy Link

@dpschen hmm yeah I think I'll have to configure that

@dpschen hmm yeah I think I'll have to configure that
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
area/internal-code
changes requested
confirmed
dependencies
duplicate
This issue or pull request already exists
good first issue
help wanted
Need some help
hosting
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/frontend#972
No description provided.
Delete Branch "feature/netlify-preview"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?