vikunja
/
helm-chart
2
2
Fork 5
Code Issues 7 Pull Requests 1 Packages Projects Releases 1 Wiki Activity

Utilize bjw-s's common Helm library. #13

Merged
konrad merged 41 commits from :new-helm-chart into main 2023-11-07 14:47:24 +00:00
Conversation 14 Commits 41 Files Changed 24 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0d72431ad7 - Show all commits

4
values.yaml
View File

@ -50,11 +50,11 @@ api:
typesense:
# Typesense will only work if it is enabled below (typesense.enabled).
url: '{{ printf "%s-typesense" .Release.Name }}'
url: "{{ printf "%s-typesense" .Release.Name }}:8108"
apiKey: "{{ .Values.typesense.env.TYPESENSE_API_KEY }}"
redis:
# Redis will only work if it is enabled below (redis.enabled).
host: '{{ printf "%s-redis-master" .Release.Name }}'
host: "{{ printf "%s-redis-master" .Release.Name }}:6379"
db: "{{ .Release.Name }}"
env:
# To utilize a secret in the environment variables, you can do something like the following: https://github.com/bjw-s/helm-charts/blob/a081de53024d8328d1ae9ff7e4f6bc500b0f3a29/charts/library/common/values.yaml#L141-L145
konrad marked this conversation as resolved Outdated
konrad commented 2023-10-10 16:40:52 +00:00
Outdated
Review
Copy Link

But the default value for this one is the one defined in the ingress, why define it here again?

But the default value for this one is the one defined in the ingress, why define it here again?
perfectra1n commented 2023-10-10 22:36:57 +00:00
Outdated
Review
Copy Link

Fair, forgot to use the ingress value for that variable as well. I went ahead and fixed it. I also included a comment to to the user incase they aren't using an ingress resource (I was even using a Service behind a central Nginx until recently)

fixed!

Fair, forgot to use the `ingress` value for that variable as well. I went ahead and fixed it. I also included a comment to to the user incase they aren't using an `ingress` resource (I was even using a `Service` behind a central Nginx until recently) fixed!
perfectra1n commented 2023-10-10 22:41:34 +00:00
Outdated
Review
Copy Link

9cd4680e70 and c601e5e449

https://kolaente.dev/vikunja/helm-chart/commit/9cd4680e707c57d06e718f8d1e6f524408965a32 and https://kolaente.dev/vikunja/helm-chart/commit/c601e5e449523ffb7feb7d35ca72389075769d9c