Utilize bjw-s's common Helm library. #13
|
|
@ -1,6 +1,19 @@
|
|||
{{- define "vikunja.backend.hardcodedValues" -}}
|
||||
global:
|
||||
nameOverride: backend
|
||||
nameOverride: backend
|
||||
|
perfectra1n marked this conversation as resolved
Outdated
|
||||
|
||||
service:
|
||||
main:
|
||||
enabled: true
|
||||
primary: true
|
||||
type: ClusterIP
|
||||
ports:
|
||||
http:
|
||||
enabled: true
|
||||
primary: true
|
||||
port: 3456
|
||||
protocol: HTTP
|
||||
|
||||
|
||||
{{ end }}
|
||||
|
||||
|
|
|
|||
|
|
@ -1,8 +1,27 @@
|
|||
{{- define "vikunja.frontend.hardcodedValues" -}}
|
||||
global:
|
||||
nameOverride: frontend
|
||||
nameOverride: frontend
|
||||
|
||||
service:
|
||||
main:
|
||||
enabled: true
|
||||
{{- if not .Values.backend.enabled -}}
|
||||
primary: true
|
||||
{{- end }}
|
||||
type: ClusterIP
|
||||
ports:
|
||||
http:
|
||||
enabled: true
|
||||
{{- if not .Values.backend.enabled -}}
|
||||
primary: true
|
||||
{{- end }}
|
||||
port: 80
|
||||
protocol: HTTP
|
||||
konrad
commented
What if the api ingress is using https? What if the api ingress is using https?
perfectra1n
commented
By default, By default, `ingress-nginx` redirects HTTP to HTTPS and the annotation `nginx.ingress.kubernetes.io/force-ssl-redirect: "true"` can be used with other Kubernetes Ingress objects to redirect HTTP to HTTPS. It's "normal" in the deployments I've created to have to create that annotation on the Ingress if I've required that redirection (or the other way around :))
|
||||
targetPort: 8080
|
||||
|
||||
env:
|
||||
- name: VIKUNJA_SERVICE_INTERFACE
|
||||
value: ":8080"
|
||||
|
||||
{{ end }}
|
||||
|
||||
|
|
|
|||
|
|
@ -46,10 +46,17 @@ frontend:
|
|||
tls: []
|
||||
|
||||
backend:
|
||||
enabled: true
|
||||
enabled: false
|
||||
image:
|
||||
repository: vikunja/api
|
||||
pullPolicy: IfNotPresent
|
||||
persistence:
|
||||
data:
|
||||
enabled: true
|
||||
# existingClaim: # your-claim
|
||||
accessMode: ReadWriteOnce
|
||||
size: 10Gi
|
||||
# storageClass: storage-class
|
||||
ingress:
|
||||
|
konrad marked this conversation as resolved
Outdated
konrad
commented
But the default value for this one is the one defined in the ingress, why define it here again? But the default value for this one is the one defined in the ingress, why define it here again?
perfectra1n
commented
Fair, forgot to use the fixed! Fair, forgot to use the `ingress` value for that variable as well. I went ahead and fixed it. I also included a comment to to the user incase they aren't using an `ingress` resource (I was even using a `Service` behind a central Nginx until recently)
fixed!
perfectra1n
commented
https://kolaente.dev/vikunja/helm-chart/commit/9cd4680e707c57d06e718f8d1e6f524408965a32 and https://kolaente.dev/vikunja/helm-chart/commit/c601e5e449523ffb7feb7d35ca72389075769d9c
|
||||
main:
|
||||
enabled: false
|
||||
|
|
|
|||
Is this a special "backend" or the api service? If it's the api, it should be called api.
(I know there are still parts of Vikunja's documentation where it's called "backend" but I'd like to get rid of that anyway)
Gotchya, I'll rename that to be
apiinstead. I sawbackendin the docs like you said, so I just ran with that.