vikunja
/
helm-chart
2
2
Fork 5
Code Issues 7 Pull Requests 1 Packages Projects Releases 1 Wiki Activity

Utilize bjw-s's common Helm library. #13

Merged
konrad merged 41 commits from :new-helm-chart into main 2023-11-07 14:47:24 +00:00
Conversation 14 Commits 41 Files Changed 24 +19 -4
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9cd4680e70 - Show all commits

13
templates/api.yaml
View File

@ -38,6 +38,19 @@ probes:
startup:
enabled: false
{{ if .Values.frontend.ingress.enabled }}
configMaps:
# The configuration for Vikunja's backend.
konrad marked this conversation as resolved Outdated
konrad commented 2023-10-11 08:35:32 +00:00
Outdated
Review
Copy Link

Nitpick, but please use "api" here instead of "backend".

Nitpick, but please use "api" here instead of "backend".
perfectra1n commented 2023-10-11 13:54:08 +00:00
Outdated
Review
Copy Link

Done:
76b209a70c :)

Done: https://kolaente.dev/vikunja/helm-chart/commit/76b209a70c3b73b8bcaeff153e8c5a56a3901975 :)
# https://vikunja.io/docs/config-options/
config:
enabled: true
data:
config.yml:
service:
# Vikunja needs to know the frontend URL for password reset emails.
frontendUrl: "http://{{ index .Values.frontend.ingress.main.hosts 0 "host" }}{{ index .Values.frontend.ingress.main.hosts 0 "path" }}"
{{ end }}
env:
{{ if .Values.redis.enabled }}
VIKUNJA_REDIS_ENABLED: "true"

10
values.yaml
View File

@ -17,7 +17,7 @@ storage:
######################
# VIKUNJA COMPONENTS #
######################
# You can find the default values
# You can find the default values that this `values.yaml` overrides, in the comment at the top of this file.
konrad marked this conversation as resolved Outdated
konrad commented 2023-10-10 16:39:43 +00:00
Outdated
Review
Copy Link

Doesn't this need a link to the docs with the default config?

Doesn't this need a link to the docs with the default config?
perfectra1n commented 2023-10-10 22:42:31 +00:00
Outdated
Review
Copy Link

fixed

d8500214e9

fixed https://kolaente.dev/vikunja/helm-chart/commit/d8500214e98def13755bad78e31e9b2e39404df1
api:
enabled: true
image:
@ -48,6 +48,11 @@ api:
enabled: true
data:
config.yml:
# Vikunja needs to know the frontend URL for password reset emails.
# So you might need to provide its value, if you're not using an ingress.
# service:
# frontendUrl: http://vikunja.local
database:
# You should provide your own secret outside of this helm-chart and use `postgresql.global.postgresql.auth.existingSecret` to provide credentials to the postgresql instance (https://github.com/bitnami/charts/blob/5ff8ad5f3c754e3c2423d6abf46f522e8abe0410/bitnami/postgresql/values.yaml#L35-L39)
type: 'postgres'
@ -55,9 +60,6 @@ api:
password: "{{ .Values.postgresql.global.postgresql.auth.password }}"
konrad marked this conversation as resolved Outdated
konrad commented 2023-10-10 16:40:52 +00:00
Outdated
Review
Copy Link

But the default value for this one is the one defined in the ingress, why define it here again?

But the default value for this one is the one defined in the ingress, why define it here again?
perfectra1n commented 2023-10-10 22:36:57 +00:00
Outdated
Review
Copy Link

Fair, forgot to use the ingress value for that variable as well. I went ahead and fixed it. I also included a comment to to the user incase they aren't using an ingress resource (I was even using a Service behind a central Nginx until recently)

fixed!

Fair, forgot to use the `ingress` value for that variable as well. I went ahead and fixed it. I also included a comment to to the user incase they aren't using an `ingress` resource (I was even using a `Service` behind a central Nginx until recently) fixed!
perfectra1n commented 2023-10-10 22:41:34 +00:00
Outdated
Review
Copy Link

9cd4680e70 and c601e5e449

https://kolaente.dev/vikunja/helm-chart/commit/9cd4680e707c57d06e718f8d1e6f524408965a32 and https://kolaente.dev/vikunja/helm-chart/commit/c601e5e449523ffb7feb7d35ca72389075769d9c
database: "{{ .Values.postgresql.global.postgresql.auth.database }}"
host: '{{ .Release.Name }}-postgresql'
service:
# Vikunja needs to know the frontend URL for password reset emails.
frontendUrl: http://vikunja.local
typesense:
# Typesense will only work if it is enabled below (typesense.enabled).
url: '{{ printf "%s-typesense" .Release.Name }}'