From 003bc80c2032b4fbf810ccf70467bf4418d6cd17 Mon Sep 17 00:00:00 2001 From: kolaente Date: Sat, 29 Dec 2018 02:34:07 +0100 Subject: [PATCH] very small performance improvment --- pkg/models/list_tasks_create_update.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/pkg/models/list_tasks_create_update.go b/pkg/models/list_tasks_create_update.go index a5600d5f0..7a7a053a3 100644 --- a/pkg/models/list_tasks_create_update.go +++ b/pkg/models/list_tasks_create_update.go @@ -166,11 +166,13 @@ func (t *ListTask) updateTaskAssignees(assignees []*User) (err error) { } // Delete all assignees not passed - _, err = x.In("user_id", assigneesToDelete). - And("task_id = ?", t.ID). - Delete(ListTaskAssginee{}) - if err != nil { - return err + if len(assigneesToDelete) > 0 { + _, err = x.In("user_id", assigneesToDelete). + And("task_id = ?", t.ID). + Delete(ListTaskAssginee{}) + if err != nil { + return err + } } // Get the list to perform later checks