From 5530e1e42e6653ef4e39b8982dceb00881d71662 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Sat, 10 Jul 2021 12:06:04 +0200
Subject: [PATCH] Add test to make sure a user only sees their favorites

---
 pkg/models/tasks_test.go | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/pkg/models/tasks_test.go b/pkg/models/tasks_test.go
index 1d6ad6acb..371a98fd4 100644
--- a/pkg/models/tasks_test.go
+++ b/pkg/models/tasks_test.go
@@ -718,14 +718,12 @@ func TestTask_ReadOne(t *testing.T) {
 		assert.True(t, IsErrTaskDoesNotExist(err))
 	})
 	t.Run("with subscription", func(t *testing.T) {
-		u = &user.User{ID: 6}
-
 		db.LoadAndAssertFixtures(t)
 		s := db.NewSession()
 		defer s.Close()
 
 		task := &Task{ID: 22}
-		err := task.ReadOne(s, u)
+		err := task.ReadOne(s, &user.User{ID: 6})
 		assert.NoError(t, err)
 		assert.NotNil(t, task.Subscription)
 	})
@@ -742,4 +740,24 @@ func TestTask_ReadOne(t *testing.T) {
 		assert.NotNil(t, task.CreatedBy)
 		assert.Equal(t, int64(-2), task.CreatedBy.ID)
 	})
+	t.Run("favorite", func(t *testing.T) {
+		db.LoadAndAssertFixtures(t)
+		s := db.NewSession()
+		defer s.Close()
+
+		task := &Task{ID: 1}
+		err := task.ReadOne(s, u)
+		assert.NoError(t, err)
+		assert.True(t, task.IsFavorite)
+	})
+	t.Run("favorite for a different user", func(t *testing.T) {
+		db.LoadAndAssertFixtures(t)
+		s := db.NewSession()
+		defer s.Close()
+
+		task := &Task{ID: 1}
+		err := task.ReadOne(s, &user.User{ID: 2})
+		assert.NoError(t, err)
+		assert.False(t, task.IsFavorite)
+	})
 }