From 693a77ae5181648876bc8bb470834b20b37d37bd Mon Sep 17 00:00:00 2001 From: kolaente Date: Fri, 25 Aug 2023 15:14:25 +0200 Subject: [PATCH] fix(user): don't prevent deleting a user if their default project was shared Resolves https://kolaente.dev/vikunja/api/issues/1595 --- pkg/models/user_delete.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/models/user_delete.go b/pkg/models/user_delete.go index c4caa42de..cfcef021f 100644 --- a/pkg/models/user_delete.go +++ b/pkg/models/user_delete.go @@ -138,7 +138,9 @@ func DeleteUser(s *xorm.Session, u *user.User) (err error) { for _, p := range projectsToDelete { err = p.Delete(s, u) - if err != nil { + // If the user is the owner of the default project it will be deleted, if they are not the owner + // we can ignore the error as the project was shared in that case. + if err != nil && !IsErrCannotDeleteDefaultProject(err) { return err } }