Refactor team member tests

Signed-off-by: kolaente <k@knt.li>

pkg/models/team_members_test.go

@@ -24,61 +24,60 @@ import (
 )
 
 func TestTeamMember_Create(t *testing.T) {
-	db.LoadAndAssertFixtures(t)
 
-	// Dummy team member
-	dummyteammember := TeamMember{
-		TeamID:   1,
-		Username: "user3",
+	doer := &user.User{
+		ID: 1,
 	}
 
-	// Doer
-	doer, err := user.GetUserByID(1)
-	assert.NoError(t, err)
-
-	// Insert a new team member
-	allowed, _ := dummyteammember.CanCreate(doer)
-	assert.True(t, allowed)
-	err = dummyteammember.Create(doer)
-	assert.NoError(t, err)
-
-	// Check he's in there
-	team := Team{ID: 1}
-	err = team.ReadOne()
-	assert.NoError(t, err)
-	assert.Equal(t, 3, len(team.Members))
-
-	// Try inserting a user twice
-	err = dummyteammember.Create(doer)
-	assert.Error(t, err)
-	assert.True(t, IsErrUserIsMemberOfTeam(err))
-
-	// Delete it
-	allowed, _ = dummyteammember.CanDelete(doer)
-	assert.True(t, allowed)
-	err = dummyteammember.Delete()
-	assert.NoError(t, err)
-
-	// Delete the other one
-	tm := TeamMember{TeamID: 1, Username: "user2"}
-	err = tm.Delete()
-	assert.NoError(t, err)
-
-	// Try deleting the last one
-	tm = TeamMember{TeamID: 1, Username: "user1"}
-	err = tm.Delete()
-	assert.Error(t, err)
-	assert.True(t, IsErrCannotDeleteLastTeamMember(err))
-
-	// Try inserting a user which does not exist
-	dummyteammember.Username = "user9484"
-	err = dummyteammember.Create(doer)
-	assert.Error(t, err)
-	assert.True(t, user.IsErrUserDoesNotExist(err))
-
-	// Try adding a user to a team which does not exist
-	tm = TeamMember{TeamID: 94824, Username: "user1"}
-	err = tm.Create(doer)
-	assert.Error(t, err)
-	assert.True(t, IsErrTeamDoesNotExist(err))
+	t.Run("normal", func(t *testing.T) {
+		db.LoadAndAssertFixtures(t)
+		tm := &TeamMember{
+			TeamID:   1,
+			Username: "user3",
+		}
+		err := tm.Create(doer)
+		assert.NoError(t, err)
+	})
+	t.Run("already existing", func(t *testing.T) {
+		db.LoadAndAssertFixtures(t)
+		tm := &TeamMember{
+			TeamID:   1,
+			Username: "user1",
+		}
+		err := tm.Create(doer)
+		assert.Error(t, err)
+		assert.True(t, IsErrUserIsMemberOfTeam(err))
+	})
+	t.Run("nonexisting user", func(t *testing.T) {
+		db.LoadAndAssertFixtures(t)
+		tm := &TeamMember{
+			TeamID:   1,
+			Username: "nonexistinguser",
+		}
+		err := tm.Create(doer)
+		assert.Error(t, err)
+		assert.True(t, user.IsErrUserDoesNotExist(err))
+	})
+	t.Run("nonexisting team", func(t *testing.T) {
+		db.LoadAndAssertFixtures(t)
+		tm := &TeamMember{
+			TeamID:   9999999,
+			Username: "user1",
+		}
+		err := tm.Create(doer)
+		assert.Error(t, err)
+		assert.True(t, IsErrTeamDoesNotExist(err))
+	})
+}
+
+func TestTeamMember_Delete(t *testing.T) {
+	t.Run("normal", func(t *testing.T) {
+		db.LoadAndAssertFixtures(t)
+		tm := &TeamMember{
+			TeamID:   1,
+			Username: "user1",
+		}
+		err := tm.Delete()
+		assert.NoError(t, err)
+	})
 }