Fix session in list duplication & routes

pkg/models/list_duplicate.go

@@ -39,7 +39,7 @@ type ListDuplicate struct {
 }
 
 // CanCreate checks if a user has the right to duplicate a list
-func (ld *ListDuplicate) CanCreate(a web.Auth, s *xorm.Session) (canCreate bool, err error) {
+func (ld *ListDuplicate) CanCreate(s *xorm.Session, a web.Auth) (canCreate bool, err error) {
 	// List Exists + user has read access to list
 	ld.List = &List{ID: ld.ListID}
 	canRead, _, err := ld.List.CanRead(s, a)

pkg/models/list_duplicate_test.go

@@ -39,7 +39,7 @@ func TestListDuplicate(t *testing.T) {
 		ListID:      1,
 		NamespaceID: 1,
 	}
-	can, err := l.CanCreate(u, s)
+	can, err := l.CanCreate(s, u)
 	assert.NoError(t, err)
 	assert.True(t, can)
 	err = l.Create(s, u)

pkg/routes/routes.go

@@ -601,11 +601,19 @@ func caldavBasicAuth(username, password string, c echo.Context) (bool, error) {
 		Username: username,
 		Password: password,
 	}
+	s := db.NewSession()
+	defer s.Close()
 	u, err := user.CheckUserCredentials(s, creds)
 	if err != nil {
+		_ = s.Rollback()
 		log.Errorf("Error during basic auth for caldav: %v", err)
 		return false, nil
 	}
+
+	if err := s.Commit(); err != nil {
+		return false, err
+	}
+
 	// Save the user in echo context for later use
 	c.Set("userBasicAuth", u)
 	return true, nil