users on lists are now referenced by their username

pkg/models/list_users.go

@@ -22,8 +22,10 @@ import "code.vikunja.io/web"
 type ListUser struct {
 	// The unique, numeric id of this list <-> user relation.
 	ID int64 `xorm:"int(11) autoincr not null unique pk" json:"id" param:"namespace"`
-	// The user id.
-	UserID int64 `xorm:"int(11) not null INDEX" json:"userID" param:"user"`
+	// The username.
+	Username string `xorm:"-" json:"username" param:"user"`
+	// Used internally to reference the user
+	UserID int64 `xorm:"int(11) not null INDEX" json:"-"`
 	// The list id.
 	ListID int64 `xorm:"int(11) not null INDEX" json:"-" param:"list"`
 	// The right this user has. 0 = Read only, 1 = Read & Write, 2 = Admin. See the docs for more details.

pkg/models/list_users_create.go

@@ -47,9 +47,11 @@ func (lu *ListUser) Create(a web.Auth) (err error) {
 	}
 
 	// Check if the user exists
-	if _, err = GetUserByID(lu.UserID); err != nil {
+	user, err := GetUser(User{Username: lu.Username})
+	if err != nil {
 		return err
 	}
+	lu.UserID = user.ID
 
 	// Check if the user already has access or is owner of that list
 	// We explicitly DONT check for teams here

pkg/models/list_users_delete.go

@@ -34,10 +34,11 @@ import _ "code.vikunja.io/web" // For swaggerdocs generation
 func (lu *ListUser) Delete() (err error) {
 
 	// Check if the user exists
-	_, err = GetUserByID(lu.UserID)
+	user, err := GetUser(User{Username: lu.Username})
 	if err != nil {
 		return
 	}
+	lu.UserID = user.ID
 
 	// Check if the user has access to the list
 	has, err := x.Where("user_id = ? AND list_id = ?", lu.UserID, lu.ListID).