From bd6493eb53b106173c8cc1e116d07ad2d03b2d1e Mon Sep 17 00:00:00 2001
From: Daniel Herrmann <daniel.herrmann1@gmail.com>
Date: Fri, 29 Mar 2024 18:39:46 +0100
Subject: [PATCH] refactor: simplify migration to single query

---
 pkg/migration/20240329170952.go | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/pkg/migration/20240329170952.go b/pkg/migration/20240329170952.go
index 464c12d3b..3f7b5c96a 100644
--- a/pkg/migration/20240329170952.go
+++ b/pkg/migration/20240329170952.go
@@ -37,23 +37,8 @@ func init() {
 		Description: "Update default filter for list views to hide completed tasks",
 		Migrate: func(tx *xorm.Engine) error {
 
-			// Use ORM to get all project views
-			projectViews := []*projectView20240329170952{}
-			err := tx.Find(&projectViews)
-			if err != nil {
-				return err
-			}
-
 			// Update the filter for all list views to hide completed tasks unless the filter is already set
-			for _, view := range projectViews {
-				if view.ViewKind == 0 && view.Filter == "" {
-					view.Filter = "done = false"
-					_, err := tx.ID(view.ID).Update(view)
-					if err != nil {
-						return err
-					}
-				}
-			}
+			tx.Where("view_kind = ? AND filter = ?", 0, "").Cols("filter").Update(&projectView20240329170952{Filter: "done = false"})
 			return nil
 		},
 		Rollback: func(tx *xorm.Engine) error {