New users can't save general settings #1211

New Issue

andreymal · 2022-07-15T16:27:17Z

andreymal commented

2022-07-15 16:27:17 +00:00

Steps to reproduce:

Register a new user and login
Go to settings
Click "Save"

Expected behavior:

Nothing, I guess? Since I left all the default settings untouched.

Actual Behavior:

Error while saving user settings:

JSON request from the frontend:

{
  "overdue_tasks_reminders_enabled": false,
  "overdue_tasks_reminders_time": "",
  // ...
}

JSON response from the server:

{
  "code": 2002,
  "message": "Invalid Data",
  "invalid_fields":
  [
    "overdue_tasks_reminders_time: non zero value required"
  ]
}

I'm not sure whether to see this as an api problem or a frontend problem, but I think the server should just ignore overdue_tasks_reminders_time when overdue_tasks_reminders_enabled is false, so I decided to create an issue in this repo.

**Steps to reproduce:** 1. Register a new user and login 2. Go to settings 3. Click "Save" **Expected behavior:** Nothing, I guess? Since I left all the default settings untouched. **Actual Behavior:** `Error while saving user settings:` JSON request from the frontend: ```json { "overdue_tasks_reminders_enabled": false, "overdue_tasks_reminders_time": "", // ... } ``` JSON response from the server: ```json { "code": 2002, "message": "Invalid Data", "invalid_fields": [ "overdue_tasks_reminders_time: non zero value required" ] } ``` I'm not sure whether to see this as an api problem or a frontend problem, but I think the server should just ignore `overdue_tasks_reminders_time` when `overdue_tasks_reminders_enabled` is false, so I decided to create an issue in this repo.

konrad added the

kind/bug

label 2022-07-19 14:38:53 +00:00

konrad referenced this issue from a commit

2022-07-19 14:38:58 +00:00

fix: return 9:00 as default time for reminders if none was set

konrad closed this issue

2022-07-19 14:38:58 +00:00

konrad commented

2022-07-19 14:39:12 +00:00

Should be fixed in 79b31673e2

Should be fixed in https://kolaente.dev/vikunja/api/commit/79b31673e2a79eaa124976840e85757d2bebb887