Can't remove shared namespace with user that has apostroph in his name #1224
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#1224
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Version information:
Frontend Version: 0.18.2
API Version: v0.18.1
Browser and OS Version: Firefox 103.0 (64-bit) / Windows 10
Steps to reproduce:
Expected behavior:
Share is removed
Actual behavior:
I get this error message:
Checklist:
I looked a bit deeper into it and the problem seems to be the URL encoding of the link, so might be a frontend issue rather than a API issue.
This is the URL I see when I try to delete the share:
http://todo.elektro.ch/api/v1/namespaces/4/users/SXXXXXXX%20D'Urso
If I urlencode the same link with one of the numerous online URL encoders, I get
http://todo.elektro.ch/api/v1/namespaces/4/users/SXXXXXXX%20D%27Urso
The
'
seems not to be encodedI did another test, I resent the DELETE request using my browsers dev tools and edited the URL by replacing
'
with%27
and that did the trick!Looks like this is a problem from the space in the username, not the apostroph.
Fixed in
8f27e7e619
- please test with the next unstable build if it fixes your issue.I'm on vacation, will test next week when I'm back 👍
Maybe I'm missing something here but: Shouldn't the api request encode the user in the first place?
@dpschen The frontend did encode it but the api didn't encode it correctly.
@konrad Solves my issue! Thank you for your fast response!