vikunja/vikunja
8
54
Fork 94
Code Issues 101 Pull Requests 31 Packages Releases 37 Activity

Reminders are not synced with caldav alarms #1408

New Issue
Closed
opened 2023-02-25 21:29:41 +00:00 by ce72 · 6 comments
ce72 commented 2023-02-25 21:29:41 +00:00
Contributor
Copy Link

Reminders are not exported as CALDAV attributes and thus do not appear on mobile clients.
Alarms from CALDAV clients are ignored.

Reminders are not exported as CALDAV attributes and thus do not appear on mobile clients. Alarms from CALDAV clients are ignored.
🚀 1
konrad added the
kind/feature
 label 2023-02-27 09:56:57 +00:00
ce72 commented 2023-03-04 12:44:12 +00:00
Author
Contributor
Copy Link

I started working on this issue, but I think it is at least in part blocked by vikunja/api#1416.

Caldav clients can deliver VALERTS which may contain
TRIGGER;VALUE=DATE-TIME:20181201T011210Z
or TRIGGER:-PT60M
or TRIGGER;RELATED=START:-P1D
or TRIGGER;RELATED=END:-PT60M
where only the first one is supported by the current Vikunja model.

I started working on this issue, but I think it is at least in part blocked by https://kolaente.dev/vikunja/api/issues/1416. Caldav clients can deliver VALERTS which may contain TRIGGER;VALUE=DATE-TIME:20181201T011210Z or TRIGGER:-PT60M or TRIGGER;RELATED=START:-P1D or TRIGGER;RELATED=END:-PT60M where only the first one is supported by the current Vikunja model.
konrad commented 2023-03-04 13:16:55 +00:00
Owner
Copy Link

So we either need to implement relative dates in Vikunja first, or recalculate relative caldav dates to absolute dates when they are changed via caldav?

So we either need to implement relative dates in Vikunja first, or recalculate relative caldav dates to absolute dates when they are changed via caldav?
ce72 commented 2023-03-04 20:48:27 +00:00
Author
Contributor
Copy Link

In fact, I implemented the recalculation to absolute dates in the PR.
But I commented this out, because I don't think it will be a good idea. It would either risk duplicate reminders on the client (the relative and the synced ones) or it could mean that the relative dates will be overwritten. It's hard to predict and probably depends on how the client does the merge. Or do you think it's safe?

But at least the absolute dates from Vikunja could be synced with the absolute dates on the caldav client (supporting TRIGGER;VALUE=DATE-TIME and ignoring others). This should be safe. Do you think we should do that as a temporary solution?

In fact, I implemented the recalculation to absolute dates in the PR. But I commented this out, because I don't think it will be a good idea. It would either risk duplicate reminders on the client (the relative and the synced ones) or it could mean that the relative dates will be overwritten. It's hard to predict and probably depends on how the client does the merge. Or do you think it's safe? But at least the absolute dates from Vikunja could be synced with the absolute dates on the caldav client (supporting TRIGGER;VALUE=DATE-TIME and ignoring others). This should be safe. Do you think we should do that as a temporary solution?
konrad commented 2023-03-05 12:24:56 +00:00
Owner
Copy Link

It's hard to predict and probably depends on how the client does the merge. Or do you think it's safe?

That is true. I don't think it is safe.

But at least the absolute dates from Vikunja could be synced with the absolute dates on the caldav client (supporting TRIGGER;VALUE=DATE-TIME and ignoring others). This should be safe. Do you think we should do that as a temporary solution?

Not sure. TBH I think we should just implement relative dates into Vikunja and then use these. That will be more work up front but will be a clean implementation and avoid ripping a version of this implemented now out.
And we can't tell the clients to not use relative dates so people will inevitable complain about how this does not work for all reminders.

> It's hard to predict and probably depends on how the client does the merge. Or do you think it's safe? That is true. I don't think it is safe. > But at least the absolute dates from Vikunja could be synced with the absolute dates on the caldav client (supporting TRIGGER;VALUE=DATE-TIME and ignoring others). This should be safe. Do you think we should do that as a temporary solution? Not sure. TBH I think we should just implement relative dates into Vikunja and then use these. That will be more work up front but will be a clean implementation and avoid ripping a version of this implemented now out. And we can't tell the clients to not use relative dates so people will inevitable complain about how this does not work for all reminders.
👍 1
konrad commented 2023-04-01 10:52:47 +00:00
Owner
Copy Link

Is this resolved by #1415?

Is this resolved by #1415?
ce72 commented 2023-04-01 11:00:21 +00:00
Author
Contributor
Copy Link

Yes.

Yes.
ce72 closed this issue 2023-04-01 11:00:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
moved-to-github
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
kind/feature
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#1408
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?