[mail] Replace logo with SVG #1478

New Issue

dpschen · 2023-04-06T10:42:33Z

dpschen commented

2023-04-06 10:42:33 +00:00

Reason

So that it isn't blurry on high dpi devices, like mobile.

### Reason So that it isn't blurry on high dpi devices, like mobile.

konrad commented

2023-04-06 11:42:52 +00:00

What about mail software support for this? IIRC quite a few clients don't support svg because you could embed code in them.

konrad commented

2023-04-06 11:43:32 +00:00

Relevant discussion: https://github.com/go-vikunja/api/issues/25#issuecomment-1083626778

dpschen commented

2023-04-06 13:07:51 +00:00

Well true: https://www.caniemail.com/features/image-svg/

EDIT:

Correcting: There is a valid workaround, see https://css-tricks.com/a-guide-on-svg-support-in-email/#aa-image-tag-with-css-hack. I wouldn't even call it a hack. It's totally valid if it works.

<img src="my-image.jpg" 
     alt="A pair of flat black dice, one on 5 and one on 3" 
     srcset="my-image.svg"
/>

Well true: https://www.caniemail.com/features/image-svg/ **EDIT:** Correcting: There is a valid workaround, see https://css-tricks.com/a-guide-on-svg-support-in-email/#aa-image-tag-with-css-hack. I wouldn't even call it a hack. It's totally valid if it works. ```html <img src="my-image.jpg" alt="A pair of flat black dice, one on 5 and one on 3" srcset="my-image.svg" /> ```

konrad commented

2023-04-06 14:01:19 +00:00

There is a valid workaround

Can we test this somehow? And wouldn't that mean we'll have to embed two images all the time?

> There is a valid workaround Can we test this somehow? And wouldn't that mean we'll have to embed two images all the time?

dpschen commented

2023-04-11 12:07:58 +00:00

Can we test this somehow?

I guess only by sending this out to an actual account.

And wouldn't that mean we'll have to embed two images all the time?

Yes. If compressed the overhead of the logo as SVG shouldn't be that large.

> Can we test this somehow? I guess only by sending this out to an actual account. > And wouldn't that mean we'll have to embed two images all the time? Yes. If compressed the overhead of the logo as SVG shouldn't be that large.

phelex commented

2023-05-09 12:48:16 +00:00

at least for macOS and iOS I'd inline the svg, since both will initially not load <img> source

at least for macOS and iOS I'd inline the svg, since both will initially not load `<img>` source

konrad referenced this issue from a commit

2024-02-07 14:00:31 +00:00

chore(deps): update dependency rollup to v2.67.0 (#1478)

Sign in to join this conversation.