Reverse the coupling of module log and config #1606

HoffmannP · 2023-09-26T14:11:19Z

HoffmannP commented

2023-09-26 14:11:19 +00:00

This way the config module can already use the log module with the same result (default logging to StdOut with Level INFO, same output as before) but ENV variables can already change the logging of config file related log output). It is now possible to dump as a cronjob without having to filter the default log about the used config file.

Also:

all logging modules are now configurable when initializing which makes testing easier
viper dependency removed from logging
log correct settings when configured error level is invalid
deprecation of value "false" for log.standard and log.events (already not mentioned in https://vikunja.io/docs/config-options/)

This way the config module can already use the log module with the same result (default logging to StdOut with Level INFO, same output as before) but ENV variables can already change the logging of config file related log output). It is now possible to dump as a cronjob without having to filter the default log about the used config file. Also: - all logging modules are now configurable when initializing which makes testing easier - viper dependency removed from logging - log correct settings when configured error level is invalid - deprecation of value "false" for log.standard and log.events (already not mentioned in https://vikunja.io/docs/config-options/)

HoffmannP added 3 commits 2023-09-26 14:11:25 +00:00

8b22f71399 Reversed dependency of config and log module so that logging can start before parsing config ENV and file.

All loggers are configured independently through the constructor
Dependency on viper solely in config module
Minor fixes in error strings in logger constructors
Using config.log.database and config.log.mail instead of values from viper

5560fc7f98 Deprecating value "false" for config.log.standard and config.log.events

continuous-integration/drone/pr Build is failing Details

ba79afe29c Typo

HoffmannP changed title from ~~Reversing the coupling of mod log and config~~ to Reversing the coupling of module log and config

2023-09-26 14:13:33 +00:00

HoffmannP changed title from ~~Reversing the coupling of module log and config~~ to Reverse the coupling of module log and config

2023-09-26 14:20:47 +00:00

HoffmannP added 1 commit 2023-09-27 10:00:23 +00:00

continuous-integration/drone/pr Build is failing Details

5af348dbe1 Change MkDir to MkDirAll so even subdirs are created

HoffmannP referenced this pull request

2023-09-27 10:01:42 +00:00

Auto-create logs-directory #1213

HoffmannP added 1 commit 2023-09-27 13:35:33 +00:00

continuous-integration/drone/pr Build is failing Details

e5ebc6ede6 Save value of configLogPath in ConfigLoogger in logging module for later use in GetLogWriter

HoffmannP commented

2023-09-27 14:52:34 +00:00

Is the constant "off" something that should be fixed?

konrad commented

2023-09-27 15:32:50 +00:00

Is the constant "off" something that should be fixed?

I think it's sufficient to add it to the ignore list.

> Is the constant "off" something that should be fixed? I think it's sufficient to add it to the ignore list.

konrad reviewed 2023-09-27 15:38:24 +00:00

pkg/config/config.go

						
				@ -415,15 +419,17 @@ func InitConfig() {

					viper.SetConfigName("config")

					err = viper.ReadInConfig()

					log.ConfigLogger(LogEnabled.GetBool(), LogStandard.GetString(), LogPath.GetString(), LogLevel.GetString())

konrad commented

2023-09-27 15:34:30 +00:00

What if reading the config fails? Isn't this call redundant then?

HoffmannP commented

2023-09-28 08:28:51 +00:00

You are right, I move it down into the if-branch

pkg/log/logging.go Outdated

						
				@ -41,42 +39,44 @@ const logModule = `vikunja`

				// loginstance is the instance of the logger which is used under the hood to log

				var logInstance = logging.MustGetLogger(logModule)

				// logpath is the path in which log files will be written. This value should actually never be used