Webhook events task.relation.created and task.relation.deleted doesn't appear to trigger #1676

New Issue

IvarMatstoms · 2024-01-04T07:51:08Z

IvarMatstoms commented

2024-01-04 07:51:08 +00:00

Description

As stated in title webhook events for "task.relation.created" and "task.relation.deleted" doesn't appear to trigger. Other events ("task.updated", "task.created", "task.deleted") works fine.

I have tried:

Restarted Vikunja server
Removed and readded the webhook
Logging all incoming requests to the webhook target server
Checked the access log for the reverse proxy connecting to the target server

Vikunja Frontend Version

0.22.0

Vikunja API Version

0.22.0

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

No

Screenshots

### Description As stated in title webhook events for "task.relation.created" and "task.relation.deleted" doesn't appear to trigger. Other events ("task.updated", "task.created", "task.deleted") works fine. I have tried: - Restarted Vikunja server - Removed and readded the webhook - Logging all incoming requests to the webhook target server - Checked the access log for the reverse proxy connecting to the target server ### Vikunja Frontend Version 0.22.0 ### Vikunja API Version 0.22.0 ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? No ### Screenshots ![2024-01-04 08.33.14.png](/attachments/6071389e-b76a-46ba-8d89-534f05d9aa3d)

2024-01-04 08.33.14.png

31 KiB

IvarMatstoms added the

kind/bug

label 2024-01-04 07:51:09 +00:00

konrad commented

2024-01-04 11:59:26 +00:00

Looks like this is the cause:

api_1       | 2024-01-04T11:56:41.964873317Z: DEBUG	▶ models/Handle ab4b event task.relation.created does not contain a project id, not handling webhook
api_1       | 2024-01-04T11:56:41.964695073Z: ERROR	▶ models/Handle ab47 Event payload does not contain task ID

Looks like this is the cause: ``` api_1 | 2024-01-04T11:56:41.964873317Z: DEBUG ▶ models/Handle ab4b event task.relation.created does not contain a project id, not handling webhook api_1 | 2024-01-04T11:56:41.964695073Z: ERROR ▶ models/Handle ab47 Event payload does not contain task ID

konrad referenced this issue from a commit

2024-01-26 23:16:32 +00:00

fix(webhooks): make sure all events with tasks have the full task

konrad closed this issue

2024-01-26 23:16:32 +00:00

konrad commented

2024-01-26 23:16:55 +00:00

Fixed in ae9b382963. Please check with the next unstable build (should be ready in ~45 min) if the problem went away.

Fixed in ae9b382963701aeb0f266c07d2dea65f76fd64e0. Please check with the next unstable build (should be ready in ~45 min) if the problem went away.

IvarMatstoms commented

2024-01-29 11:31:19 +00:00

I checked the unstable build, and the events trigger properly, thank you!