[Bug/inconvenience] Refreshing whilst task is open "closes" the list #1808

New Issue

Gensokian · 2021-07-12T09:20:41Z

Gensokian commented

2021-07-12 09:20:41 +00:00

When opening a task from the List view, or refreshing the page whilst having the floating editor open in the KANBAN view opens the task in a "Full screen" editor.

I am not able to see any way to return to the list besides either clicking the list again in the sidebar (Which is tideous when using a lot of namespaces/lists) or clicking the listname in the breadcrumbs in the top-left

A "Done" or "X" button on the top/bottom right side would be an intuitive addition so the user can easily return to where they were.

When opening a task from the List view, or refreshing the page whilst having the floating editor open in the KANBAN view opens the task in a "Full screen" editor. I am not able to see any way to return to the list besides either clicking the list again in the sidebar (Which is tideous when using a lot of namespaces/lists) or clicking the listname in the breadcrumbs in the top-left A "Done" or "X" button on the top/bottom right side would be an intuitive addition so the user can easily return to where they were.

konrad commented

2021-07-12 10:29:24 +00:00

You could use the back button of your browser. That would take you back to the kanban view.
Another option would also be to click on the list title beneath the task title though that will not take you back to the kanban view.

The problem is there's no way to find out from the url alone if the task detail view was opened from kanban or any other view.

You could use the back button of your browser. That would take you back to the kanban view. Another option would also be to click on the list title beneath the task title though that will not take you back to the kanban view. The problem is there's no way to find out from the url alone if the task detail view was opened from kanban or any other view.

Gensokian commented

2021-07-12 10:47:32 +00:00

Couldn't somethign like this fit the job?

<button onclick="done()">Done!</button>

<script>
function done() {
  window.history.back();
}
</script>

Edit:

Googled shortly, found this one-liner
<a href="javascript:history.back()">Done!</a>

I'll look into the project-code today eve.

Couldn't somethign like this fit the job? ``` <button onclick="done()">Done!</button> <script> function done() { window.history.back(); } </script> ``` Edit: Googled shortly, found this one-liner `<a href="javascript:history.back()">Done!</a>` I'll look into the project-code today eve.

konrad commented

2021-07-12 10:51:13 +00:00

That would interfer with the "Done" button on the page which is used to mark the task as done. You would also need to make sure it is only shown when there is something in the history (not sure if that's even possible?).

A cleaner solution would maybe be to put some query string or something like that in the url when the task detail view was opened from kanban and then check if that's present when loading and open the popup again in that case.

That would interfer with the "Done" button on the page which is used to mark the task as done. You would also need to make sure it is only shown when there is something in the history (not sure if that's even possible?). A cleaner solution would maybe be to put some query string or something like that in the url when the task detail view was opened from kanban and then check if that's present when loading and open the popup again in that case.

Gensokian commented

2021-07-16 07:04:56 +00:00

I just thought about this again, what if the button would just use the same link of the list, the task is in?

konrad commented

2021-07-17 16:41:45 +00:00

Like the list title underneath the task title?

Gensokian commented

2021-07-19 05:29:10 +00:00

Exactly, that one allways brings the user to the list, no matter if the task is opened in the list view as fullscreen, or floating like in the kanban view

konrad referenced this issue from a commit

2021-07-19 09:20:14 +00:00

Fix sending the user back to the list view they came from when opening a task in detail view

konrad closed this issue

2021-07-19 09:20:14 +00:00

konrad commented

2021-07-19 09:21:23 +00:00

Fixed in b812c422f9 - Now clicking on the list title will take you back to the view you originally came from.

I had some logic in there (which didn't work), now it seems to work better.

Fixed in b812c422f97945c818e437b42b152a86a4766d4b - Now clicking on the list title will take you back to the view you originally came from. I had some logic in there (which didn't work), now it seems to work better.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1808