Don't reset activeFields after editing some field #1809
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#1809
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
There's a small UI glitch in the task detail view:
The end date field became visible, but disappeared immediately after saving start date, so I have to click "Set an end date" again.
It's easy to see that hiding is caused by calling setActiveFields() in the
saveTask
method, so I think there is a need to remember fields fields that should remain active after saving (or just deleting this call, but it exists for some reason?)(I wanted to make a PR but couldn't come up with a variable name 🙁)
(P.S. There are many small UI glitches, maybe I'll create a meta-issue someday)
I think that call to
setActiveFields()
is save to remove. IIRC I've put it in back then precisely because I wanted to hide all fields without a value after one was set.Another way to solve this would be to add a check to see if a new field was called (click on a "set"-button while another dialog was still open) but I think that'd get very complicated very quickly.
Fixed in
68a76faacc
- sorry it took so long.Please check with the next unstable release (for example on try once the CI released it (~30 min).