Don't reset activeFields after editing some field #1809

New Issue

andreymal · 2021-07-12T14:29:54Z

andreymal commented

2021-07-12 14:29:54 +00:00

There's a small UI glitch in the task detail view:

Click "Set a start date"
Set some date, but don't click "Confirm"
Click "Set an end date" while the start date widget is still open

The end date field became visible, but disappeared immediately after saving start date, so I have to click "Set an end date" again.

It's easy to see that hiding is caused by calling setActiveFields() in the saveTask method, so I think there is a need to remember fields fields that should remain active after saving (or just deleting this call, but it exists for some reason?)

(I wanted to make a PR but couldn't come up with a variable name 🙁)

(P.S. There are many small UI glitches, maybe I'll create a meta-issue someday)

There's a small UI glitch in the task detail view: 1. Click "Set a start date" 2. Set some date, but don't click "Confirm" 3. Click "Set an end date" while the start date widget is still open The end date field became visible, but disappeared immediately after saving start date, so I have to click "Set an end date" again. It's easy to see that hiding is caused by calling [setActiveFields()](https://kolaente.dev/vikunja/frontend/src/commit/7355204d2f7367a52d27b5079087b231c6caf5ae/src/views/tasks/TaskDetailView.vue#L615) in the `saveTask` method, so I think there is a need to remember fields fields that should remain active after saving (or just deleting this call, but it exists for some reason?) (I wanted to make a PR but couldn't come up with a variable name 🙁) (P.S. There are many small UI glitches, maybe I'll create a meta-issue someday) ![](https://i.imgur.com/ZIDPZL3.gif)

konrad commented

2021-07-13 10:32:47 +00:00

I think that call to setActiveFields() is save to remove. IIRC I've put it in back then precisely because I wanted to hide all fields without a value after one was set.

Another way to solve this would be to add a check to see if a new field was called (click on a "set"-button while another dialog was still open) but I think that'd get very complicated very quickly.

I think that call to `setActiveFields()` is save to remove. IIRC I've put it in back then precisely because I wanted to hide all fields without a value after one was set. Another way to solve this would be to add a check to see if a new field was called (click on a "set"-button while another dialog was still open) but I think that'd get very complicated very quickly.

konrad added the

kind/bug

label 2021-07-13 10:32:51 +00:00

konrad referenced this issue from a commit

2022-01-08 14:13:59 +00:00

fix: don't reset active fields when saving

konrad closed this issue

2022-01-08 14:14:00 +00:00

konrad commented

2022-01-08 14:14:48 +00:00

Fixed in 68a76faacc - sorry it took so long.

Please check with the next unstable release (for example on try once the CI released it (~30 min).

Fixed in 68a76faacc004c3c9e3b4d0d91f98036b300d339 - sorry it took so long. Please check with the next unstable release (for example on [try](https://try.vikunja.io) once the CI released it (~30 min).

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1809