vikunja/vikunja
Archived
8
54
Fork 94
Code Issues 101 Pull Requests 31 Packages Releases 37 Activity

Duplicate "edit" action in task detail if no description available. #1844

New Issue
Closed
opened 2021-10-04 13:50:39 +00:00 by dpschen · 4 comments
dpschen commented 2021-10-04 13:50:39 +00:00
Member
Copy Link

One of those should be removed.

I was not sure of all the cases that the Editor component supports so I didn't want to break anything.

One of those should be removed. I was not sure of all the cases that the Editor component supports so I didn't want to break anything.
Screenshot 2021-10-04 at 15.48.39.png
12 KiB
Screenshot 2021-10-04 at 15.48.39.png
dpschen added the
changes requested
 label 2021-10-04 13:50:39 +00:00
konrad commented 2021-10-04 18:19:56 +00:00
Owner
Copy Link

Maybe that can be changed to only show the edit button (below) when there is some text?

Maybe that can be changed to only show the edit button (below) when there is some text?
dpschen commented 2021-10-04 18:31:17 +00:00
Author
Member
Copy Link

Yes that makes sense. I didn't create a pull request because I was not sure if I'm correctly understand all the possible cases (there are a lot of combinations).

Yes that makes sense. I didn't create a pull request because I was not sure if I'm correctly understand all the possible cases (there are a lot of combinations).
konrad commented 2021-10-04 19:04:42 +00:00
Owner
Copy Link

I think the task description and comments are the only cases when edit is enabled, have you checked that?

I think the task description and comments are the only cases when edit is enabled, have you checked that?
konrad self-assigned this 2021-10-04 19:15:42 +00:00
konrad commented 2021-10-04 19:20:49 +00:00
Owner
Copy Link

Fixed in 19a561c8e6

Fixed in https://kolaente.dev/vikunja/frontend/commit/19a561c8e6cdd43f8bca246e1a883cd642e11ccb
🎉 1
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
moved-to-github
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees konrad
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#1844
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?