vikunja/vikunja
8
54
Fork 94
Code Issues 130 Pull Requests 35 Packages Releases 37 Activity

time fields in calendar widget don't update unless you click away first #1904

New Issue
Open
opened 2022-02-09 15:15:34 +00:00 by Ghost · 9 comments
Ghost commented 2022-02-09 15:15:34 +00:00
Copy Link

In any place where the calendar view shows up (e.g. deferring from list view, editing the due date from task detail, or modifying the ranges in "Upcoming"), when I edit the time I have to click away from either the hours or the minutes in order for it to actually update. So if I type 23<Tab>30 and then click "confirm", it only saves the hours and not the minutes. But if I click on the hours again and then click "confirm" it saves both fields.

In any place where the calendar view shows up (e.g. deferring from list view, editing the due date from task detail, or modifying the ranges in "Upcoming"), when I edit the time I have to click away from either the hours or the minutes in order for it to actually update. So if I type `23<Tab>30` and then click "confirm", it only saves the hours and not the minutes. But if I click on the hours again and then click "confirm" it saves both fields.
Ghost changed title from time fields in calendar view don't update unless you click away first to time fields in calendar widget don't update unless you click away first 2022-02-09 15:16:33 +00:00
konrad commented 2022-02-09 15:32:39 +00:00
Owner
Copy Link

I think that's an issue with the way the flatpickr component is set up in vue. Not sure if there's much we can do about that.

I think that's an issue with the way the flatpickr component is set up in vue. Not sure if there's much we can do about that.
Ghost commented 2022-02-10 14:03:01 +00:00
Author
Copy Link

Any chance you could point me upstream to where I can file a bug report on this? Seems like a common enough problem to want solved generally.

Any chance you could point me upstream to where I can file a bug report on this? Seems like a common enough problem to want solved generally.
konrad commented 2022-02-10 22:08:05 +00:00
Owner
Copy Link

Sure! The component we're using is this one: https://github.com/ankurk91/vue-flatpickr-component

Feel free to ping me in any issues you create (@kolaente on github).

Sure! The component we're using is this one: https://github.com/ankurk91/vue-flatpickr-component Feel free to ping me in any issues you create (@kolaente on github).
Ghost commented 2022-02-10 22:49:04 +00:00
Author
Copy Link

What versions of vue.js, flatpickr, and vue-flatpickr-component are we using?

Does it seem reasonable for me to use Vikunja to demonstrate the bug? I'm a little worried I won't be able to produce a MWE.

What versions of vue.js, flatpickr, and vue-flatpickr-component are we using? Does it seem reasonable for me to use Vikunja to demonstrate the bug? I'm a little worried I won't be able to produce a MWE.
konrad commented 2022-02-11 07:30:32 +00:00
Owner
Copy Link

All versions are here: https://kolaente.dev/vikunja/frontend/src/branch/main/package.json#L47

I think you can use Vikunja to demonstrate the bug. If they want a minimal reproducible version we can build one.

All versions are here: https://kolaente.dev/vikunja/frontend/src/branch/main/package.json#L47 I think you can use Vikunja to demonstrate the bug. If they want a minimal reproducible version we can build one.
konrad commented 2022-02-11 07:31:36 +00:00
Owner
Copy Link

Even better yet, the bug is reproducible in their demo: https://ankurk91.github.io/vue-flatpickr-component/

Even better yet, the bug is reproducible in their demo: https://ankurk91.github.io/vue-flatpickr-component/
Ghost commented 2022-02-11 14:19:19 +00:00
Author
Copy Link

Really? It's actually working for me there just fine.

Really? It's actually working for me there just fine.
konrad commented 2022-02-13 12:34:06 +00:00
Owner
Copy Link

Now that you say it... looks like it yes. Not quite sure how to proceed here.

@dpschen Do you have an idea?

Now that you say it... looks like it yes. Not quite sure how to proceed here. @dpschen Do you have an idea?
dpschen commented 2022-05-21 14:24:51 +00:00
Member
Copy Link

Sorry for getting back so late. Somehow I missed this.
The vue-flatpickr-component is written really bad.
I want to replace it with a custom solution (because flatpickr itself is fine).

Sorry for getting back so late. Somehow I missed this. The vue-flatpickr-component is written really bad. I want to replace it with a custom solution (because flatpickr itself is fine).
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#1904
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?