vikunja/vikunja
8
54
Fork 94
Code Issues 130 Pull Requests 35 Packages Releases 37 Activity

[Repository] Adjust Labels for Pull Requests #1906

New Issue
Open
opened 2022-02-20 10:25:17 +00:00 by dpschen · 3 comments
dpschen commented 2022-02-20 10:25:17 +00:00
Member
Copy Link

Currently the labels in Pull Requests seem to be ones that are made for Issues.

E.g.

  • every Pull Request should have the label "changes requested".
  • what would a Pull Request be that is labeled as "question"
  • [...]

I didn't check but might it be that you can only generaly create labels in Gitea and there is no separation between labels for Issues and Pull Requests? If so, maybe we can add some labels that are better fitting for Pull Requests. Maybe adding a prefix (e.g. PR: ).

Currently the labels in Pull Requests seem to be ones that are made for Issues. E.g. - every Pull Request should have the label "changes requested". - what would a Pull Request be that is labeled as "question" - [...] I didn't check but might it be that you can only generaly create labels in Gitea and there is no separation between labels for Issues and Pull Requests? If so, maybe we can add some labels that are better fitting for Pull Requests. Maybe adding a prefix (e.g. `PR: `).
konrad commented 2022-02-20 16:38:48 +00:00
Owner
Copy Link

I think Gitea doesn't differentiate between labels of PRs and issues. Under the hood, each PR has an issue linked to it.

I think Gitea doesn't differentiate between labels of PRs and issues. Under the hood, each PR has an issue linked to it.
dpschen commented 2022-02-20 17:13:37 +00:00
Author
Member
Copy Link

I think Gitea doesn't differentiate between labels of PRs and issues. Under the hood, each PR has an issue linked to it.

Interesting! What do you think of the prefix-idea?

> I think Gitea doesn't differentiate between labels of PRs and issues. Under the hood, each PR has an issue linked to it. Interesting! What do you think of the prefix-idea?
konrad commented 2022-02-20 17:27:28 +00:00
Owner
Copy Link

If there's a label thatt would only work for an issue or a PR I think adding a prefix to them would make a lot of sense. For the rest, we might just want to be careful what to apply where so labels like "question" don't end up on PRs.

If there's a label thatt would only work for an issue or a PR I think adding a prefix to them would make a lot of sense. For the rest, we might just want to be careful what to apply where so labels like "question" don't end up on PRs.
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#1906
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?