Error: [vuex] do not mutate vuex store state outside mutation handlers #1945
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When editing some fields (including but not limited to: priority, date, progress, assignees) from the Kanban view (i.e. via
task-detail-view-modal
), the following error occurs:or:
Can you reproduce this on https://try.vikunja.io ?
Which version are you running on?
@dpschen i use the git main branch with
yarn serve
But your question made me check
yarn build
and I noticed that the compiled frontend does not have this error, hencetry.vikunja.io
does not have this error either.Does it mean this is a bug somewhere inside the
yarn serve
implementation?When using build the error will not be logged. Sometimes there are errors that are minor, so we don't want to annoy the user. In development (aka
yarn serve
) we want to see every problem.The vuex issues you are seeing are not minor though. That should never happen.
@konrad Do we have a central place where we track these?
I don't think we have a place for those yet. Maybe we should just open an issue? Or better yet, fix when they come up?
Closing since we migrated to pina since this was opened.
I'm not sure but we might still be doing this.
To be absolutely sure that we do not change outsite of actions (since mutations and actions are unified in pinia) we would need to export only refs wrapped in
readonly()
. Most stores do that, but not all of them.