Notifications are not localized #2019

Open
opened 2023-03-08 09:36:41 +00:00 by WofWca · 1 comment
Contributor

Description

"Vikunja Reminder" and "Show task" strings are not localized.

src/models/task.ts Lines 230 to 241 in 0ff0d8c5b8
registration.showNotification('Vikunja Reminder', {
tag: `vikunja-task-${this.id}`, // Group notifications by task id so we're only showing one notification per task
body: this.title,
// eslint-disable-next-line no-undef
showTrigger: new TimestampTrigger(date),
badge: '/images/icons/badge-monochrome.png',
icon: '/images/icons/android-chrome-512x512.png',
data: {taskId: this.id},
actions: [
{
action: 'show-task',
title: 'Show task',

I'm not sure if simply replacing them with t('... is right as the language can be changed in the user setting at any time.

Vikunja Frontend Version

2262b49aaf

Vikunja API Version

v1

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

### Description "Vikunja Reminder" and "Show task" strings are not localized. https://kolaente.dev/vikunja/frontend/src/commit/0ff0d8c5b89bd6a8b628ddbe6074f61797b6b9c1/src/models/task.ts#L230-L241 I'm not sure if simply replacing them with `t('...` is right as the language can be changed in the user setting at any time. ### Vikunja Frontend Version 2262b49aaf8270b727020ee52f1e7ed30ee00694 ### Vikunja API Version v1 ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_
WofWca added the
kind/bug
label 2023-03-08 09:36:41 +00:00
Owner

That whole code is dead code as Google sunsetted the Chrome api we used to schedule the notifications. I think we should remove it. Or maybe save it for a time when we implement this with common browser notifications? But if we do that we can always get it back from git history so I'd say let's remove it.

That whole code is dead code as Google sunsetted the Chrome api we used to schedule the notifications. I think we should remove it. Or maybe save it for a time when we implement this with common browser notifications? But if we do that we can always get it back from git history so I'd say let's remove it.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#2019
No description provided.