Filter pop-up cannot be dismissed with Esc when a text or dropdown field has focus #2052

New Issue

SteveDinn · 2023-05-05T14:54:22Z

SteveDinn commented

2023-05-05 14:54:22 +00:00

Description

Click the Filters button to bring up the Filters pop-up.
Set the focused control to be any of the text fields or drop downs.
Hit Esc. to your heart's content, but nothing happens.

Reproduced on https://try.vikunja.io.

Vikunja Frontend Version

0.20.5+250-b25c5ff547

Vikunja API Version

v0.20.4+107-9c66b473dd

Browser and version

Firefox 112.0.2 (64-bit) Windows 10

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

### Description * Click the Filters button to bring up the Filters pop-up. * Set the focused control to be any of the text fields or drop downs. * Hit Esc. to your heart's content, but nothing happens. Reproduced on [https://try.vikunja.io](https://try.vikunja.io). ### Vikunja Frontend Version 0.20.5+250-b25c5ff547 ### Vikunja API Version v0.20.4+107-9c66b473dd ### Browser and version Firefox 112.0.2 (64-bit) Windows 10 ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_

SteveDinn added the

kind/bug

label 2023-05-05 14:54:22 +00:00

konrad commented

2023-05-06 16:04:05 +00:00

I feel like that's a problem all modals have.

@dpschen Didn't we start a fix for this already somewhere?

I feel like that's a problem all modals have. @dpschen Didn't we start a fix for this already somewhere?

konrad commented

2023-05-06 16:05:26 +00:00

I think what we're looking for is the dialog element?

I think what we're looking for is [the dialog element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog)?