"Please provide a title for the filter" warning given when title already filled out, prevents saving #2084

New Issue

BV · 2023-12-22T20:10:00Z

BV commented

2023-12-22 20:10:00 +00:00

Description

When editing a project filter you get the warning "Please provide a title for the filter" even when the title is already filled out and it prevents you from saving unless put focus in the title field and move focus away from the title field again. You don't actually have to change the title.

Vikunja Frontend Version

0.22.0

Vikunja API Version

0.22.0

Browser and version

Edge 120.0.2210.77 & Chrome 120.0.6099.129

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

### Description When editing a project filter you get the warning "Please provide a title for the filter" even when the title is already filled out and it prevents you from saving unless put focus in the title field and move focus away from the title field again. You don't actually have to change the title. ### Vikunja Frontend Version 0.22.0 ### Vikunja API Version 0.22.0 ### Browser and version Edge 120.0.2210.77 & Chrome 120.0.6099.129 ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots ![image](/attachments/01c24ce0-2350-499d-9e9b-fc4f077d02ab)

image.png

7.5 KiB

image.png

9.2 KiB

BV added the

kind/bug

label 2023-12-22 20:10:00 +00:00

konrad commented

2024-01-21 19:32:22 +00:00

Thank you for the report.

How did you open the title field without having the input focused right away? I was not able to reproduce this using the following steps:

Open an existing saved filter
Click on "edit" in the three-dots menu next to the title
Hit the "save" button (does not seem to matter if you actually change any of the filter values)

As expected, the filter is saved and the popup closes.

Thank you for the report. How did you open the title field without having the input focused right away? I was not able to reproduce this using the following steps: 1. Open an existing saved filter 2. Click on "edit" in the three-dots menu next to the title 3. Hit the "save" button (does not seem to matter if you actually change any of the filter values) As expected, the filter is saved and the popup closes.

BV commented

2024-01-21 23:03:22 +00:00

I just tried it in the demo site.

Click Project
Create a new filter
Save it
When the new project opens click ... > Edit at the top

The cursor focus should be in the title field and show the red message in the screenshot from the original issues report. Click Description or anywhere else and it remains.

Same thing happens if I click the ... > Edit in the left menu

I just tried it in the demo site. 1. Click Project 2. Create a new filter 3. Save it 4. When the new project opens click ... > Edit at the top The cursor focus should be in the title field and show the red message in the screenshot from the original issues report. Click Description or anywhere else and it remains. Same thing happens if I click the ... > Edit in the left menu

konrad commented

2024-01-22 11:07:55 +00:00

Still wasn't able to reproduce. Can you share a screen recording?

BV commented

2024-01-25 04:24:12 +00:00

See attached video. Near the end I ended up putting a space in the title before navigating away and saving successfully but you don't need to. You only need to tab out of the field. Clicking focus away from it, like clicking into description, does not get rid of the error for me. The recorded example was in Safari on macOS but the same thing happened in Chrome in Edge on windows as per the original report.

bug example.mov

14 MiB

konrad commented

2024-01-26 10:31:42 +00:00

Still wasn't able to reproduce it consistently, but managed to see the behaviour you're describing once in a Windows 10 vm with Edge. I've pushed a potential fix in e3cae0ed7f - please check with the next unstable build (ready in ~45 min) if the problem still happens.

Still wasn't able to reproduce it consistently, but managed to see the behaviour you're describing once in a Windows 10 vm with Edge. I've pushed a potential fix in e3cae0ed7fe098094255b85ff277b9a0a3d8c51f - please check with the next unstable build (ready in ~45 min) if the problem still happens.

konrad referenced this issue from a commit

2024-01-26 10:31:51 +00:00

fix(filter): validate filter title field after loading a filter for edit

konrad commented

2024-02-06 17:47:02 +00:00

This was reported as fixed via email, closing. Please ping again if you still have issues.

konrad closed this issue

2024-02-06 17:47:02 +00:00

konrad referenced this issue from a commit

2024-02-07 14:00:35 +00:00

chore(deps): update dependency vue-tsc to v0.38.2 (#2084)

Sign in to join this conversation.