Requests to /api/v1 may return html #2110

New Issue

ce72 · 2024-02-13T06:49:21Z

ce72 commented

2024-02-13 06:49:21 +00:00

Description

Up to release 0.23.0 calling GET /api/v1/tasks/999999 resulted in a 404 response with a body like {"code":4002,"message":"This task does not exist"}

When performing the same call to the recent 0.23.0 version it returns 200 OK with an HTML content. This happens even when setting the HTTP Header Accept=application/json.
This breaks expectations of CLI tools like vja or curl based scripts. There seems to be a global 404 handling which might be too global?

Vikunja Version

0.23.0

Browser and version

cli

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

### Description Up to release 0.23.0 calling `GET /api/v1/tasks/999999` resulted in a 404 response with a body like `{"code":4002,"message":"This task does not exist"}` When performing the same call to the recent 0.23.0 version it returns 200 OK with an HTML content. This happens even when setting the HTTP Header `Accept=application/json`. This breaks expectations of CLI tools like vja or curl based scripts. There seems to be a global 404 handling which might be too global? ### Vikunja Version 0.23.0 ### Browser and version cli ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_

ce72 added the

kind/bug

label 2024-02-13 06:49:21 +00:00

konrad referenced this issue from a commit

2024-02-13 09:05:28 +00:00

fix: never return frontend on routes starting with /api

konrad closed this issue

2024-02-13 09:05:28 +00:00

konrad commented

2024-02-13 09:05:53 +00:00

Should be fixed in 641fec1215 - please check with the next unstable build (ready in ~45min) or on try.

Should be fixed in https://kolaente.dev/vikunja/vikunja/commit/641fec12157504b8ed2935ba9943828662a725f9 - please check with the next unstable build (ready in ~45min) or on try.

👍 1

Sign in to join this conversation.