TypeError when opening specific projects #2246

New Issue

benimautner · 2024-04-03T12:42:58Z

benimautner commented

2024-04-03 12:42:58 +00:00

Description

When opening specific projects from the https://try.vikunja.io/projects page, the site hangs and throws below error in the console endlessly:
runtime-core.esm-bundler.js:195 [Vue warn]: Error in https://vuejs.org/error-reference/#runtime-1: "TypeError: Cannot read properties of undefined (reading 'length')" (found in <Anonymous>)

This only happens with projects that have a background image and at least one task.

Steps to reproduce:

Create a new project
Add a task to the project
Add background to the project
Go to https://try.vikunja.io/projects and click on it

Vikunja Version

v0.23.0+438-f0d695e789

Browser and version

Google Chrome 119.0.6045.160 (Official Build) (64-Bit) (cohort: Stable)

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

### Description When opening specific projects from the https://try.vikunja.io/projects page, the site hangs and throws below error in the console endlessly: ```runtime-core.esm-bundler.js:195 [Vue warn]: Error in https://vuejs.org/error-reference/#runtime-1: "TypeError: Cannot read properties of undefined (reading 'length')" (found in <Anonymous>)``` This only happens with projects that have a background image and at least one task. Steps to reproduce: - Create a new project - Add a task to the project - Add background to the project - Go to https://try.vikunja.io/projects and click on it ### Vikunja Version v0.23.0+438-f0d695e789 ### Browser and version Google Chrome 119.0.6045.160 (Official Build) (64-Bit) (cohort: Stable) ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots ![image](/attachments/eeb4bd6b-fd50-4904-8e9e-ff7e80813591)

image.png

65 KiB

benimautner added the

kind/bug

label 2024-04-03 12:42:58 +00:00

konrad commented

2024-04-04 15:46:56 +00:00

Maybe related to https://github.com/go-vikunja/vikunja/issues/233

konrad referenced this issue from a commit

2024-04-07 12:55:15 +00:00

fix(project): return the full project when setting a background

konrad commented

2024-04-07 12:57:09 +00:00

I couldn't exactly reproduce it with the same error message, however I was able to trigger an error when setting a background image on a new project. This should be fixed with 8bee5aa806 - please check with the next unstable build if that fixes your issue as well (I was not able to reproduce it with that commit anymore, but it might have been a different issue I fixed)

I couldn't exactly reproduce it with the same error message, however I was able to trigger an error when setting a background image on a new project. This should be fixed with https://kolaente.dev/vikunja/vikunja/commit/8bee5aa8063fcae317bfd42c4a6dc6126fe13a13 - please check with the next unstable build if that fixes your issue as well (I was not able to reproduce it with that commit anymore, but it might have been a different issue I fixed)

benimautner commented

2024-04-07 17:08:18 +00:00

Unfortunately that doesn't fix it. I've fixed it for me with this: https://kolaente.dev/benimautner/vikunja/src/branch/fix_redirecttofirstviewifnecessary

I've never used Vue before, so I might be lacking some basic understanding about the inner workings of the framework. Just let me know if I should change anything. If you think it's fine I can create a pull request.

Unfortunately that doesn't fix it. I've fixed it for me with this: https://kolaente.dev/benimautner/vikunja/src/branch/fix_redirecttofirstviewifnecessary I've never used Vue before, so I might be lacking some basic understanding about the inner workings of the framework. Just let me know if I should change anything. If you think it's fine I can create a pull request.

konrad commented

2024-04-13 11:06:23 +00:00

I guess this is the same as https://community.vikunja.io/t/vikunja-freezes/2246/5 ?

konrad referenced this issue from a commit

2024-04-13 11:18:34 +00:00

fix(project): do not crash when views were not loaded yet

konrad commented

2024-04-13 11:20:00 +00:00

This time I was able to reproduce it properly, pushed a fix in 9eb19e0362. Please check with the next unstable build (ready in ~45min, also on try) if the problem went away.

There was nothing wrong with the fix you proposed, I've just decided to add the fallback at the root, rather than in the template :)

This time I was able to reproduce it properly, pushed a fix in https://kolaente.dev/vikunja/vikunja/commit/9eb19e03626087f8a8aae72cc9d659db7b0505a8. Please check with the next unstable build (ready in ~45min, also on try) if the problem went away. There was nothing wrong with the fix you proposed, I've just decided to add the fallback at the root, rather than in the template :)

benimautner commented

2024-04-13 19:16:34 +00:00

Perfect, it now works on try.
Yeah no, that fix makes a lot more sense :)

I don't know whether you want to keep this open until you release the fix, but it's fixed now, so feel free to close the issue!

Perfect, it now works on try. Yeah no, that fix makes a lot more sense :) I don't know whether you want to keep this open until you release the fix, but it's fixed now, so feel free to close the issue!

konrad closed this issue

2024-04-13 19:17:04 +00:00

Sign in to join this conversation.