Column Sort does not reset when column is hidden in Table View #2272

New Issue

treysullivent · 2024-04-17T05:34:45Z

treysullivent commented

2024-04-17 05:34:45 +00:00

Description

When viewing tasks in Table view, the UI allows you to sort the table by column. If there is a sort applied on one column (even a hidden column), clicking to apply a sort on another column appears to create a multi-level sort. Most of the time, this is undesirable in my view, but I will address this in a comment.

BUG:
If there is a sort applied to a column, and that column is hidden, I assert that it is a bug that the sort status for that column is not reset to default.

Vikunja Version

Demo Site v0.23.0+526-392ce66edb

Browser and version

Firefox 124.0.2, Chrome 123.0.6312.123, Edge 123.0.2420.97

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

Sort By Column (# column used here)
Hide that Column
Try To Apply Another Sort (Due Date used here)
Notice that the filter is not applied, or is applied "under" the first filter.

### Description When viewing tasks in Table view, the UI allows you to sort the table by column. If there is a sort applied on one column (even a hidden column), clicking to apply a sort on another column appears to create a multi-level sort. Most of the time, this is undesirable in my view, but I will address this in a comment. **BUG:** If there is a sort applied to a column, and that column is hidden, I assert that it is a bug that the sort status for that column is not reset to default. ### Vikunja Version Demo Site v0.23.0+526-392ce66edb ### Browser and version Firefox 124.0.2, Chrome 123.0.6312.123, Edge 123.0.2420.97 ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots 1. Sort By Column (# column used here) ![image](/attachments/cb348eee-eb8b-456a-9ccb-0652ebcc579f) 2. Hide that Column ![image](/attachments/3dca23f5-671f-43b2-bcd3-a45b874549b2) 3. Try To Apply Another Sort (Due Date used here) ![image](/attachments/7fdbe8d8-4acc-49a8-89dd-db88c9857a18) 4. Notice that the filter is not applied, or is applied "under" the first filter.

image.png

56 KiB

image.png

62 KiB

image.png

51 KiB

image.png

51 KiB

treysullivent added the

kind/bug

label 2024-04-17 05:34:45 +00:00

konrad commented

2024-04-17 09:49:32 +00:00

Do you feel like an adequate solution here would be to remove the sorting when the column is hidden?

Related forum discussion: https://community.vikunja.io/t/feature-add-option-to-disable-multi-level-sort-in-table-view/2262/2

Do you feel like an adequate solution here would be to remove the sorting when the column is hidden? Related forum discussion: https://community.vikunja.io/t/feature-add-option-to-disable-multi-level-sort-in-table-view/2262/2

treysullivent commented

2024-04-17 14:09:44 +00:00

Yes, I think removing the sorting when column is hidden would completely fix the (what I view as a) bug.

As you can see from my discussion post you linked, I also have some other opinions about sorting, but those felt more like "Feature Requests" than a bug, because I assumed multi-level sort was currently the intended design.

Yes, I think removing the sorting when column is hidden would completely fix the (what I view as a) bug. As you can see from my discussion post you linked, I also have some other opinions about sorting, but those felt more like "Feature Requests" than a bug, because I assumed multi-level sort was currently the intended design.

👍 1

konrad referenced this issue from a commit

2024-04-21 21:48:57 +00:00

fix(table view): do not sort table column fields when the field in question is hidden

konrad closed this issue

2024-04-21 21:48:57 +00:00

konrad commented

2024-04-21 21:49:38 +00:00

This should now be fixed in d86fdcb756, please check with the next unstable build (should be ready for deployment in ~45min, also on try).

This should now be fixed in https://kolaente.dev/vikunja/vikunja/commit/d86fdcb75664cfb87044b37f29598ba73c87f190, please check with the next unstable build (should be ready for deployment in ~45min, also on [try](https://try.vikunja.io)).

Sign in to join this conversation.