vikunja/vikunja
5
48
Fork 86
Code Issues 150 Pull Requests 40 Packages Releases 37 Activity

Past date ranges seem to be reversed #2343

New Issue
Open
opened 2024-06-02 17:13:45 +00:00 by andreymal · 1 comment
andreymal commented 2024-06-02 17:13:45 +00:00
Contributor
Copy Link

Description

There's my understanding of date ranges:

  • today: 2024-06-02
  • this week: 2024-05-27 .. 2024-06-02 (assuming Monday is the first day of the week)
  • beginning of this week: 2024-05-27
  • end of this week: 2024-06-02
  • last week: 2024-05-20 .. 2024-05-26
  • beginning of last week: 2024-05-20
  • end of last week: 2024-05-26

However, the actual date ranges seem to be reversed:

  • 'beginningOflastWeek': 'now/w-1w' — 2024-05-20 (ok)

  • 'endOfLastWeek': 'now/w-2w' — 2024-05-13 (?????)

  • 'lastWeek': ['now/w-1w', 'now/w-2w'] — 2024-05-20 .. 2024-05-13 (????????????)

Same with months.

Is this a bug, or am I missing something?

Vikunja Version

any

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

### Description There's my understanding of date ranges: * today: 2024-06-02 * this week: 2024-05-27 .. 2024-06-02 (assuming Monday is the first day of the week) * beginning of this week: 2024-05-27 * end of this week: 2024-06-02 * last week: 2024-05-20 .. 2024-05-26 * beginning of last week: 2024-05-20 * end of last week: 2024-05-26 However, [the actual date ranges](https://kolaente.dev/vikunja/vikunja/src/commit/aac01c7a35836421c17882b4f77334fc14bfeaec/frontend/src/components/date/dateRanges.ts) seem to be reversed: * `'beginningOflastWeek': 'now/w-1w'` — 2024-05-20 (ok) * `'endOfLastWeek': 'now/w-2w'` — 2024-05-13 (?????) * `'lastWeek': ['now/w-1w', 'now/w-2w']` — 2024-05-20 .. 2024-05-13 (????????????) Same with months. Is this a bug, or am I missing something? ### Vikunja Version any ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_
vikunja-last-week1.png
20 KiB
vikunja-last-week1.png
andreymal added the
kind/bug
 label 2024-06-02 17:13:45 +00:00
andreymal changed title from Past date ranges seem to be inverted to Past date ranges seem to be reversed 2024-06-02 17:15:25 +00:00
konrad commented 2024-06-02 19:23:42 +00:00
Owner
Copy Link

This looks like a bug.

endOfLastWeek should be something like now/w-1w-1d (start of this week, minus one week, minus one day). If this should be "friday of last week" as in, end of the work week, this would be different still.

lastWeek seems to be off by one week and one day.

This looks like a bug. `endOfLastWeek` should be something like `now/w-1w-1d` (start of this week, minus one week, minus one day). If this should be "friday of last week" as in, end of the work week, this would be different still. `lastWeek` seems to be off by one week and one day.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
kind/bug
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2343
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?