vikunja/vikunja
5
49
Fork 89
Code Issues 132 Pull Requests 32 Packages Releases 37 Activity

New query filter is not working correctly #2547

New Issue
Closed
opened 2024-07-10 10:03:13 +00:00 by problembasedperson · 2 comments
problembasedperson commented 2024-07-10 10:03:13 +00:00
Copy Link

Description

Hello.

I'm trying the new query filter system since my instance updated to 0.24. Sadly, it doesn't seem to be working when aggregating tasks from multiple projects, or even just showing done tasks. It is reproducible on try.vikunja.io.

Steps to reproduce:

  1. Create two test projects and fill it with any number of test tasks.
  2. Create a filter with the following query: project in testProject1, testProject2.
  3. Vikunja will complain of an Invalid task filter value..

On the other hand, done = true doesn't work:

  1. Create a test project and fill it with any number of test tasks.
  2. Mark any test task as done.
  3. Create a filter with the following query: done = true.
  4. Every task, done or not, disappears.

Thanks for you work, hope it helps.

Regards,
PBP.

Vikunja Version

v0.24.0

Browser and version

Firefox 127.0.2

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

### Description Hello. I'm trying the new query filter system since my instance updated to 0.24. Sadly, it doesn't seem to be working when aggregating tasks from multiple projects, or even just showing done tasks. It is reproducible on [try.vikunja.io](https://try.vikunja.io). Steps to reproduce: 1. Create two test projects and fill it with any number of test tasks. 2. Create a filter with the following query: `project in testProject1, testProject2`. 3. Vikunja will complain of an `Invalid task filter value.`. On the other hand, `done = true` doesn't work: 1. Create a test project and fill it with any number of test tasks. 2. Mark any test task as done. 3. Create a filter with the following query: `done = true`. 4. Every task, done or not, disappears. Thanks for you work, hope it helps. Regards, PBP. ### Vikunja Version v0.24.0 ### Browser and version Firefox 127.0.2 ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_
problembasedperson added the
kind/bug
 label 2024-07-10 10:03:13 +00:00
konrad commented 2024-07-11 10:24:43 +00:00
Owner
Copy Link

Fixed in 38c30d1eee. Please check with the next unstable build.

I was unable to reproduce the second bug you mentioned. I did find one caveat though: The list view has a done = false filter set by default. This filter is used in combination with the "main" one of a saved filter, which means that when you set a done = true filter for a saved filter, the effective filter executed by Vikunja is actually done = true && done = false, resulting in no tasks shown at all. Once you remove the filter for the list view in the saved filter, it all works as expected.

EDIT: I've changed this in 5644130f01 so that the list view of a new saved filter does not have a default filter on top.

Fixed in https://kolaente.dev/vikunja/vikunja/commit/38c30d1eee27ceb9431a8e322f9265859a77d09b. Please check with the next unstable build. I was unable to reproduce the second bug you mentioned. I did find one caveat though: The list view has a `done = false` filter set by default. This filter is used in combination with the "main" one of a saved filter, which means that when you set a `done = true` filter for a saved filter, the effective filter executed by Vikunja is actually `done = true && done = false`, resulting in no tasks shown at all. Once you remove the filter for the list view in the saved filter, it all works as expected. EDIT: I've changed this in 5644130f012901975e4b1eca79b997d7350f0463 so that the list view of a new saved filter does not have a default filter on top.
👍 1
problembasedperson commented 2024-07-12 16:19:27 +00:00
Author
Copy Link

Yes, I can confirm is now working correctly. Thanks for the quick fix. I'm loving the granularity of the new filter system 🚀

Yes, I can confirm is now working correctly. Thanks for the quick fix. I'm loving the granularity of the new filter system 🚀
❤️ 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
kind/bug
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2547
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?