Accessing a task via the notification panel causes an issue where a comment/file/public share action shows on the users previous viewed card. #938

New Issue

lawless · 2021-08-11T19:14:31Z

lawless commented

2021-08-11 19:14:31 +00:00

Description:
The issue is when a user clicks the notification bell in the header and goes to that card. any action on that card is not saved on that card, but the card that the user was previously at before. For this use case I created a new board with 3 tasks (two would have been fine)and shared a public link that i accessed in a new private browser. My account is using chrome and the "public" account firefox.

Steps to reproduce

Create list with two or three tasks.
Create a public share link (or you can do this with any user on a shared board of the server.)
Comment as a public/password protected user on any card
As the user of vikunja I was viewing task 3 while I received the notification. when you get the notifcation click it.
Comment on card
go back to public view, comment is not there, it's on card task #3
This was the card i as the vikunja user was at prior to clicking the notification in the header

It took us a little while to figure out what was going on, in some cases private boards had comments on completely unrelated boards. So depending on what board that user is at prior to clicking the notification icon.

Description: The issue is when a user clicks the notification bell in the header and goes to that card. any action on that card is not saved on that card, but the card that the user was previously at before. For this use case I created a new board with 3 tasks (two would have been fine)and shared a public link that i accessed in a new private browser. My account is using chrome and the "public" account firefox. **Steps to reproduce** * Create list with two or three tasks. ![](https://lawless.world/wp-content/uploads/2021/08/Screen-Shot-2021-08-11-at-2.06.51-PM.png) * Create a public share link (or you can do this with any user on a shared board of the server.) * Comment as a public/password protected user on any card ![](https://lawless.world/wp-content/uploads/2021/08/Screen-Shot-2021-08-11-at-1.56.15-PM.png) * As the user of vikunja I was viewing task 3 while I received the notification. when you get the notifcation click it. ![](https://lawless.world/wp-content/uploads/2021/08/Screen-Shot-2021-08-11-at-1.54.48-PM.png) * Comment on card ![](https://lawless.world/wp-content/uploads/2021/08/Screen-Shot-2021-08-11-at-1.56.15-PM.png) * go back to public view, comment is not there, it's on card task #3 This was the card i as the vikunja user was at prior to clicking the notification in the header ![Comment not there](https://lawless.world/wp-content/uploads/2021/08/Screen-Shot-2021-08-11-at-1.56.54-PM.png) ![](https://lawless.world/wp-content/uploads/2021/08/Screen-Shot-2021-08-11-at-1.57.35-PM.png) It took us a little while to figure out what was going on, in some cases private boards had comments on completely unrelated boards. So depending on what board that user is at prior to clicking the notification icon.

konrad commented

2021-08-11 19:30:57 +00:00

Can confirm this is an issue still in the latest version. I'll take a look.

konrad added the

kind/bug

label 2021-08-11 19:31:02 +00:00

lawless commented

2021-08-11 19:41:12 +00:00

Can confirm this is an issue still in the latest version. I'll take a look.

awesome, other than that and the caldav to iOS issue this is working great. great job on this Konrad.

on a side note, i've been beta testing focal board from mattermost and the llama has put it to shame. You've done an amazing job on this system.

> Can confirm this is an issue still in the latest version. I'll take a look. awesome, other than that and the caldav to iOS issue this is working great. great job on this Konrad. on a side note, i've been beta testing focal board from mattermost and the llama has put it to shame. You've done an amazing job on this system. ![](https://lawless.world/wp-content/uploads/2021/08/Screen-Shot-2021-08-11-at-2.39.57-PM.png)

konrad commented

2021-08-11 20:59:28 +00:00

on a side note, i've been beta testing focal board from mattermost and the llama has put it to shame. You've done an amazing job on this system.

Thanks, that's great to hear. I think their idea of different views is certainly an interesting one to explore for Vikunja.

> on a side note, i've been beta testing focal board from mattermost and the llama has put it to shame. You've done an amazing job on this system. Thanks, that's great to hear. I think their idea of different views is certainly an interesting one to explore for Vikunja.

konrad commented

2021-08-11 21:19:28 +00:00

The bug with the comments should be fixed in fde931eaf4 (that is, I could not reproduce it anymore with the fix in the commit). It was fully a frontend issue, no api releated changes.

Please try the new unstable frontend release or on try in ~30min when the CI released a new version.

Btw thanks for the detailed steps to reproduce, that made it a lot easier to verify and fix the bug.

The bug with the comments should be fixed in https://kolaente.dev/vikunja/frontend/commit/fde931eaf4540ff5ec42cbdb7feed73469efc880 (that is, I could not reproduce it anymore with the fix in the commit). It was fully a frontend issue, no api releated changes. Please try the new unstable frontend release or on try in ~30min when the CI released a new version. Btw thanks for the detailed steps to reproduce, that made it a lot easier to verify and fix the bug.

👍 1

konrad closed this issue

2021-08-11 21:19:32 +00:00

konrad referenced this issue from a commit

2024-02-07 14:00:28 +00:00

fix(style) restrict new task input size (#938)

Sign in to join this conversation.