vikunja/vikunja
5
49
Fork 89
Code Issues 132 Pull Requests 33 Packages Releases 37 Activity

[Feature Request] Assign teams from OpenID Connect claims #950

New Issue
Closed
opened 2021-08-17 19:11:05 +00:00 by EternalDeiwos · 5 comments
EternalDeiwos commented 2021-08-17 19:11:05 +00:00
Copy Link

It would be fantastic to optionally add users to teams based on provided claims (if they are available/configured).

It would be fantastic to optionally add users to teams based on provided claims (if they are available/configured).
🎉 2
konrad commented 2021-08-17 19:22:17 +00:00
Owner
Copy Link

Would you do that with a custom claim in the id token or by some logic based on the existing claims?

How would you specify the team users get added to?

Would you do that with a custom claim in the id token or by some logic based on the existing claims? How would you specify the team users get added to?
konrad added the
kind/feature
 label 2021-08-17 19:22:38 +00:00
EternalDeiwos commented 2021-08-18 05:15:12 +00:00
Author
Copy Link

It would probably be a custom claim. None of the standard OIDC claims are viable. If you had a "groups" claim (either string or array of strings) then it should add users to each of the corresponding teams or create the teams if they don't exist.

I'd recommend having an environment variable that configures which claim Vikunja looks for, as different IdPs will provide similar values but under different claim names.

This could be for either ID token or the user info endpoint.

It would probably be a custom claim. None of the standard OIDC claims are viable. If you had a "groups" claim (either string or array of strings) then it should add users to each of the corresponding teams or create the teams if they don't exist. I'd recommend having an environment variable that configures which claim Vikunja looks for, as different IdPs will provide similar values but under different claim names. This could be for either ID token or the user info endpoint.
konrad commented 2021-08-18 15:14:53 +00:00
Owner
Copy Link

That makes sense. You would probably need to pass in the id of the team and not the name because names aren't unique.

That makes sense. You would probably need to pass in the id of the team and not the name because names aren't unique.
xeruf commented 2022-07-13 11:21:09 +00:00
Copy Link

Yes please! I now have to prompt all people to log in so I can assign them to the team, which is rather annoying.

An option to share something for everyone on the instance would be handy here, too.

Yes please! I now have to prompt all people to log in so I can assign them to the team, which is rather annoying. An option to share something for everyone on the instance would be handy here, too.
viehlieb commented 2022-10-12 13:21:17 +00:00
Contributor
Copy Link

Hello. I am currently working on that feature.

there are several specifications that need to be adressed:
vikunja/api#1393

Hello. I am currently working on that feature. there are several specifications that need to be adressed: https://kolaente.dev/vikunja/api/pulls/1393
🎉 2
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
kind/feature
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#950
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?